Skip to content

Conversation

@stweil
Copy link
Contributor

@stweil stweil commented Dec 22, 2025

No description provided.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
@stweil
Copy link
Contributor Author

stweil commented Dec 22, 2025

The container image based on php:8.4-apache-bookworm is 738 MB, the new one based on php:8.4-apache-trixie is 712 MB.

I also tried to create an image based on Debian:trixie-slim. This uses less than 400 MB, and I think that it also simplifies the Docker build. Is it desired to use php:8.4-apache-*?

And wouldn't it be easier to use a single container which also includes the database instead of using a composer setting with two containers?

@markusweigelt
Copy link
Contributor

markusweigelt commented Dec 22, 2025

The container image based on php:8.4-apache-bookworm is 738 MB, the new one based on php:8.4-apache-trixie is 712 MB.

Thx for the update i will check this.

I also tried to create an image based on Debian:trixie-slim. This uses less than 400 MB, and I think that it also simplifies the Docker build. Is it desired to use php:8.4-apache-*?

You can certainly make it smaller. However, I think that using a custom-built base image increases the maintenance effort for the image. In my opinion, this is not justified by the additional 300 MB of required storage. Since the image is intended to be maintained by the community, I personally prefer the one liner of extending from php:8.4-apache image.

And wouldn't it be easier to use a single container which also includes the database instead of using a composer setting with two containers?

No, because my reason was that existing databases can be used, and it is generally more modular (Single Responsibility). Additionally, this reduces complexity and therefore the potential errors that can occur when maintaining the image.

Ultimately, the image can also be used as a parent image, and the database can be installed afterward.

@beatrycze-volk beatrycze-volk added the 🛠️ maintenance A task to keep the code up-to-date and manageable. label Jan 2, 2026
@beatrycze-volk beatrycze-volk added this to the DFG-Viewer 8.0.0 milestone Jan 2, 2026
@beatrycze-volk beatrycze-volk merged commit c2c994a into slub:master Jan 15, 2026
12 checks passed
@stweil stweil deleted the dockerfile branch January 15, 2026 20:58
@markusweigelt
Copy link
Contributor

I was ill and couldn’t review the code. Thx @stweil for your work!

As of this year, I’m working on another project and unfortunately won’t be able to maintain the Docker image anymore. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🛠️ maintenance A task to keep the code up-to-date and manageable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants