Skip to content

[FEATURE] Add Kitodo Mediaplayer functionality in typoscript and templates#252

Open
fschoelzel wants to merge 4 commits intoslub:mainfrom
fschoelzel:252-add-mediaplayer-functionality
Open

[FEATURE] Add Kitodo Mediaplayer functionality in typoscript and templates#252
fschoelzel wants to merge 4 commits intoslub:mainfrom
fschoelzel:252-add-mediaplayer-functionality

Conversation

@fschoelzel
Copy link
Copy Markdown
Contributor

@fschoelzel fschoelzel self-assigned this Mar 25, 2026
@fschoelzel fschoelzel added the enhancement New feature or request label Mar 25, 2026
@@ -0,0 +1,31 @@
<html xmlns:f="http://typo3.org/ns/TYPO3/CMS/Fluid/ViewHelpers"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this partial not included already in Kitodo?

Copy link
Copy Markdown
Contributor Author

@fschoelzel fschoelzel Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this Partial is derived from the KitodoPageView.html Partial.
I wanted to make the decision early loading the right Partial already in the parent Template, instead of 3x if Conditions in the KitodoPageView.html to reduce complexity.
But i can also change this to use KitodoPageView.html with if conditions for each cObject.

@fschoelzel fschoelzel force-pushed the 252-add-mediaplayer-functionality branch from fd986e2 to 33549f5 Compare March 26, 2026 15:25
@fschoelzel fschoelzel marked this pull request as draft March 26, 2026 16:17
@fschoelzel fschoelzel marked this pull request as ready for review March 26, 2026 17:49
@ByteParty
Copy link
Copy Markdown
Contributor

Why are you introducing a new naming convention and not calling the media template “Mediaview,” just like “Pageview” for books?

@fschoelzel fschoelzel force-pushed the 252-add-mediaplayer-functionality branch from 33549f5 to 4d0b616 Compare March 31, 2026 12:23
@fschoelzel
Copy link
Copy Markdown
Contributor Author

Why are you introducing a new naming convention and not calling the media template “Mediaview,” just like “Pageview” for books?

@ByteParty Good hint. I changed the naming.

@fschoelzel fschoelzel marked this pull request as draft March 31, 2026 13:49
@fschoelzel fschoelzel marked this pull request as ready for review March 31, 2026 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants