[Encryption] Attempt to update Hive Integration + REST-Spark Integration#6
Draft
smaheshwar-pltr wants to merge 15 commits intomainfrom
Draft
[Encryption] Attempt to update Hive Integration + REST-Spark Integration#6smaheshwar-pltr wants to merge 15 commits intomainfrom
smaheshwar-pltr wants to merge 15 commits intomainfrom
Conversation
update snapshot producer update the patch clean up fix for previous patch address review comments move key wrapping to metadata encryption encrypt manifest list key metadata new aad util null key needs no encryption comment; clearer method/var names use key encryption key for manifest list keys add encryption util changes update EncryptionTestHelpers handle api change remove unused lines revert revapi.yml KEK cache unitest update rename var address review comments fix timeout default change writer kek timeout default Updates from review. cache unwrapped keys
Co-authored-by: Ryan Blue <rdblue@gmail.com>
This reverts commit 8aec89c.
smaheshwar-pltr
commented
Nov 14, 2024
Comment on lines
+60
to
+62
| public void setEncryptionManager(EncryptionManager em) { | ||
| this.em = em; | ||
| } |
Owner
Author
There was a problem hiding this comment.
Not ideal. Hacky way of fixing the issue of the IO tracker invoking ops.io() before a commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.