Use yq for initscript #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Sorry for the delay. I'm taking a look at this now. In the future, please bump the helm chart version, so that the linter works properly. Have you tested this locally? |
Collaborator
|
looking further at this, I think there was a reason we weren't using the yq image directly 🤔 I can't remember what it was though. Can you please bump the helm chart version and test locally that everything works? |
Contributor
Author
|
Hi! I'm actually using my fork of this repo in production Maybe an issue you were facing was related to missing file permissions? I had to add a block that makes it respect my (and yes, will bump version in the future! sorry for any trouble) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it such that during the
add-secret-values-to-configinitContainer step, instead of using thedebian:bookworm-slimimage and then installingyqonto it, we use themikefarah/yq:4image right away.My main motivation for this change was that this plays nicer with NetworkPolicies, as the current version requires the user to provide wide-ranging egress access rights to the MAS pod. (And also, it took me a very long time to figure out why the settings didn't populate properly, since the
add-secret-values-to-configcontainer currently doesn't exit on error - this change is likely going to save NetworkPolicy users a lot of troubleshooting)