Skip to content

Conversation

@J4NS-R
Copy link
Contributor

@J4NS-R J4NS-R commented Mar 13, 2025

At the moment, the env var PEERTUBE_TRUST_PROXY gets rendered like so:

- name: PEERTUBE_TRUST_PROXY
  value: "['10.0.0.0/8']"

This is actually invalid json. Strings in json have to use double-quotes. The startup logs confirm this:

SyntaxError: __format parser error in PEERTUBE_TRUST_PROXY: Unexpected token ' in JSON at position 1
    at JSON.parse (<anonymous>)
    at Parser.jsonParser (/app/node_modules/config/parser.js:158:17)
    at Config.util.parseString (/app/node_modules/config/lib/config.js:898:12)
    at _substituteVars (/app/node_modules/config/lib/config.js:1103:36)
    at Config.util.substituteDeep (/app/node_modules/config/lib/config.js:1120:3)
    at /app/node_modules/config/lib/config.js:1145:43
    at Array.forEach (<anonymous>)
    at Config.util.getCustomEnvVars (/app/node_modules/config/lib/config.js:1142:16)
    at Config.util.loadFileConfigs (/app/node_modules/config/lib/config.js:701:28)
    at new Config (/app/node_modules/config/lib/config.js:113:27)

Flipping around the quotes should fix the problem.

@J4NS-R
Copy link
Contributor Author

J4NS-R commented Mar 13, 2025

@cloudymax can I get a review please?

Copy link
Collaborator

@cloudymax cloudymax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr! I bumped the helm chart and regenerated the docs as well.

Cheers!

@cloudymax cloudymax merged commit 276512e into small-hack:main Mar 15, 2025
1 of 3 checks passed
@J4NS-R
Copy link
Contributor Author

J4NS-R commented Mar 17, 2025

Clutch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants