correct extraEnv descriptions for deployment #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I was using them to template out extra environment variables from ConfigMaps actually, so they can work that way, but that's not necessary. let me submit a fix to your fix haha |
jessebot
reviewed
Jan 21, 2025
jessebot
reviewed
Jan 21, 2025
holysoles
force-pushed
the
fix_extraenvfrom_description
branch
from
e0ee2ec to
5978ffe
Compare
Contributor
Author
|
updated! |
jessebot
reviewed
Jan 23, 2025
jessebot
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this as I was looking into passing in passport keys
Edit: maybe i'm just misunderstanding the descriptions..