Skip to content

Conversation

@holysoles
Copy link
Contributor

@holysoles holysoles commented Jan 23, 2025

I found we need to make sure a queue worker (Horizon) starts, otherwise certain things dont work (i.e. deleting posts). While I opened this PR for the docker image, as Matt notes, it'd probably be better for scalability to run it in a separate deployment.

Changes in MR:

  • in current state, set the new image ENABLE_HORIZON env var to true
  • if .Values.pixelfed.horizon.separate_deployment is true, create deployment_backend.yaml which deploys the same app image, but with an overridden command/args to run Horizon explicitly (related docs suggesting this for compose). I've also removed some env vars that I don't expect to need for that process. More cleanup may be possible.
  • I had to adjust labels to ensure only the frontend/web pod gets selected by the service. Certainly open to edit suggestions there

We could make this the default, but for complexities sake, might not be worth it

@holysoles holysoles changed the title Allow running Horizon in seperate deployment Add support for separate Horizon deployment Jan 23, 2025
@jessebot jessebot self-requested a review January 23, 2025 07:32
@jessebot
Copy link
Collaborator

OK, this seems good to me. Let's keep it as optional for now, at least until I can properly test it out :) Thank you as always for your contributions!

@jessebot
Copy link
Collaborator

Side comment, but for some reason, the helm docs action I run on this repo never works on your branches. It works when I open a PR directly on this repo though. The whole point of it is supposed to be that it updates your branch for you, so that you don't have to remember to run helm-docs locally. Maybe it's a permissions thing? We can worry about that later though. For now, I just committed the doc updates directly myself. :)

@jessebot jessebot merged commit 57f6020 into small-hack:main Jan 23, 2025
2 of 4 checks passed
@holysoles
Copy link
Contributor Author

Side comment, but for some reason, the helm docs action I run on this repo never works on your branches. It works when I open a PR directly on this repo though. The whole point of it is supposed to be that it updates your branch for you, so that you don't have to remember to run helm-docs locally. Maybe it's a permissions thing? We can worry about that later though. For now, I just committed the doc updates directly myself. :)

I've noticed it doesnt work for me as well.. I'll look later to see if i can notice anything about why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants