Minor improvements

[huang-jy]

This PR addresses two issues found during testing.

1. When installing the chart on minikube, the PostgreSQL chart complained about permissions. This has been addressed in Portainer: mkdir: cannot create directory ‘/bitnami/postgresql/data’: Permission denied bitnami/containers#2680 (comment) and the PR includes this in the values (but commented out so as not to break anything). OP on this linked issue used Microk8s, and I was using Minikube. Locally testing this addition worked.

2. Running the chart with the OOTB values breaks when starting up the main pod due to a missing config key (username). Instead of it breaking during pod startup, I changed the template to fail the install outright if the values are not defined. An alternate solution would be to change the deployment.yaml to include MAIL_USERNAME and MAIL_PASSWORD optionally rather than always.

pixelfed-chart/charts/pixelfed/templates/deployment.yaml

Lines 149 to 169 in cf128bf

	- name: MAIL_USERNAME
	valueFrom:
	secretKeyRef:
	{{- if .Values.pixelfed.mail.existingSecret }}
	name: {{ .Values.pixelfed.mail.existingSecret }}
	key: {{ .Values.pixelfed.mail.existingSecretKeys.username }}
	{{- else }}
	name: {{ include "pixelfed.fullname" . }}-mail
	key: username
	{{- end }}
	- name: MAIL_PASSWORD
	valueFrom:
	secretKeyRef:
	{{- if .Values.pixelfed.mail.existingSecret }}
	name: {{ .Values.pixelfed.mail.existingSecret }}
	key: {{ .Values.pixelfed.mail.existingSecretKeys.password }}
	{{- else }}
	name: {{ include "pixelfed.fullname" . }}-mail
	key: password
	{{- end }}

[huang-jy]

Looks like VSCode was being too smart for its own good 😅

[jessebot]

Please bump the helm chart version in Chart.yaml, and run helm-docs from the chart directory and we should be good to go :) Thank you!

[jessebot]

thanks for your contribution! :)