fixes for the valkey values section #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
holysoles
changed the title
jessebot
reviewed
Jan 18, 2025
jessebot
reviewed
Jan 18, 2025
jessebot
reviewed
Jan 18, 2025
Collaborator
|
Awesome, thanks again! Just bumped the chart version and regenerated the docs after adding a few minor values.yaml comment changes :) |
jessebot
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues i ran into in this part of the values file:
authkey and I don't think they're being passed down properly as a result.FLUSHDBcommand to be available, and the bitnami chart (and others i think) disable theFLUSHDBandFLUSHALLcommands by default. This was throwing an exception for me on startup since a DB migration script ends up callingCache::clear. I've keptFLUSHALLdisabled since I havent experienced it being necessary.