fix(chart): add parameter for service.targetPort #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a value for
service.targetPort. While not explicitly necessary, we do need to pass anAPP_PORTenv variable to the docker image for the entrypoint script to correctly configure the nginx config file. Otherwise, nginx throws an error about "too many arguments:Alternatively, we could just populate the
APP_PORTenv variable with.Values.service.port