Skip to content

Conversation

@holysoles
Copy link
Contributor

This PR adds a value for service.targetPort. While not explicitly necessary, we do need to pass an APP_PORT env variable to the docker image for the entrypoint script to correctly configure the nginx config file. Otherwise, nginx throws an error about "too many arguments:

nginx: [emerg] invalid number of arguments in "listen" directive in /etc/nginx/nginx.conf:66

Alternatively, we could just populate the APP_PORT env variable with .Values.service.port

@holysoles
Copy link
Contributor Author

@jessebot FYI this is the last PR i have for now, i was able to get the webserver running with these fixes. I haven't touched any administration or anything yet though

@holysoles holysoles force-pushed the add_target_port_value branch from 4621a01 to f3ceca0 Compare January 17, 2025 23:35
@jessebot
Copy link
Collaborator

Thanks for all your hard work! Please just remember to bump the helm chart version and run helm-docs in the future, to speed up the merge process. Really appreciate you hammering this out though! 🙏

@jessebot jessebot merged commit 1316a97 into small-hack:main Jan 18, 2025
2 of 4 checks passed
@holysoles holysoles deleted the add_target_port_value branch January 18, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants