Skip to content

Conversation

@MarcMcIntosh
Copy link
Contributor

@MarcMcIntosh MarcMcIntosh commented Feb 21, 2025

@MarcMcIntosh MarcMcIntosh changed the base branch from main to dev February 21, 2025 12:46
Copy link
Member

@alashchev17 alashchev17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It mostly works, a few adjustments are required:

  1. There is no chatId exposed
  2. When accepting or rejecting changes, code lenses which are rendered for approval or rejection stay in the same place after action
    image

Copy link
Member

@alashchev17 alashchev17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will publish new version of chat-js and then we can merge this

@alashchev17 alashchev17 marked this pull request as ready for review February 26, 2025 12:44
@alashchev17 alashchev17 merged commit ac34e1a into dev Feb 26, 2025
6 checks passed
@alashchev17 alashchev17 deleted the apply-accept-reject branch February 26, 2025 12:45
alashchev17 added a commit that referenced this pull request Mar 25, 2025
* chore(hidden features): add defaults to initail state.

* feat(knowledge): add workspace to initial state and event handler for changing workspace.

* chore(hcat-js): bump to `v2.0.6-alpha.0` for knowledge.

* chore(chat): version "~v2.0.6-alpha.1, type export fixes

* chore(new patches): remove code no longer used by chat

* feat: handle tool edit results from chat.

* refactor(patch actions): remove `ideCreateNewFile.match(e)`.

* fix(chat): thread type update.

* chore: bump chat to `v2.0.8-alpha.2` for new patch actions.

* Version bump 190225 (#189)

* 6.1.1

* 6.1.2

* 6.1.3

* fix workflow for refact repo

* readme update

* sublist

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update package.json

* Update README.md

* Update README.md

* Update package.json

* version bump 6.1.4 & [email protected]

---------

Co-authored-by: Kirill Starkov <[email protected]>
Co-authored-by: oxyplay <[email protected]>

* chore: version bump 6.1.5

* Apply accept reject (#191)

* feat(chat): send events back to chat when accepting changes in the ide.

* fix(chat ide tool call): pass chatId ide back to chat when done.

* refactor(tool edit): remove chat id from the payload.

* Revert "refactor(tool edit): remove chat id from the payload."

This reverts commit 8defbcf.

 Changes to be committed:
	modified:   src/sidebar.ts

* diff: save on accept.

* [email protected] version bump

---------

Co-authored-by: alashchev17 <[email protected]>
Co-authored-by: Andrii Lashchov <[email protected]>

* 6.1.6

* 6.1.7

* 6.1.8

* 6.1.9

* fix gh release flow

* cicd: use refact repo chat artifacts instead npm

* 6.1.10

* 6.1.11

* 6.1.12

* 6.1.13

* 6.1.14

* 6.1.15

* Version bump/6.1.16 (#197)

* version bump 6.1.16

* 6.1.17

* 6.1.18

* 6.1.19

* 6.1.20

* feat: keep indent for selected snippet.

* chore: remove console.log.

* remove knowledge flag.

* 6.2.1

* 6.2.2

* 6.2.3 version bump

* feat: knowledge option

* chore: version bump 6.2.4

* chore: version bump 6.2.5

* 6.2.6

* chore: version bump 6.2.7

* chore: version bump 6.2.8

* chore: version bump 6.3.0

---------

Co-authored-by: Andrii Lashchov <[email protected]>
Co-authored-by: Kirill Starkov <[email protected]>
Co-authored-by: oxyplay <[email protected]>
Co-authored-by: alashchev17 <[email protected]>
Co-authored-by: Oleg Klimov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants