Regex search tool for pattern matching in files #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JegernOUTT
force-pushed
the
engine/regex-search-tool
branch
3 times, most recently
from
96bb12d to
b9a9adf
Compare
- Introduce `ToolRegexSearch` to perform regex-based searches in specified file scopes. - Integrate new tool into tools_description and tools module. - Implement functionality for searching within entire workspace, specific directories, or individual files. - Support case-sensitive searches and limit results with 'max_results' parameter. - Provide detailed progress updates during search execution. - Handle invalid regex patterns gracefully with error messages.
Eliminate `case_sensitive` and `max_results` parameters to simplify the regex search tool. Update the regex pattern description to indicate the use of `(?i)` for case-insensitivity directly within the pattern. Adjust related code logic to accommodate the removal, ensuring that the search function no longer checks or enforces maximum result limits and handles pattern validation without conditional alterations for case sensitivity. This streamlines the function and reduces unnecessary complexity.
Introduce a new `scope_utils` module to streamline the process of resolving scope strings into file lists and creating SQL-like filters. Refactor existing search functionalities to utilize this common utility, reducing redundancy and improving maintainability. Implement functions `resolve_scope`, `create_scope_filter`, and `validate_scope_files` to handle scope-related operations efficiently. Update `tool_search.rs` and `tool_regex_search.rs` to integrate with the new utility, ensuring consistent scope handling across different tools.
JegernOUTT
force-pushed
the
engine/regex-search-tool
branch
from
b9a9adf to
0f1e741
Compare
olegklimov
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToolRegexSearchto perform regex-based searches in specified file scopes.