Closed
Conversation
This change prevents that some wildcard `?` gets unintentionally "changed" to `? extends java.lang.Object` if a new `ClassType` for `java.lang.Object` is constructed (again)
Contributor
Author
|
Depends on #589 |
snazy
force-pushed
the
repro-indexes-2
branch
from
7bd9f1b to
41b46fc
Compare
Checking for object-instance-equality for `Type` does sadly not always work, which is addressed by the new specialized `TypeReferenceTable` type. Similarly, the object-instance-equality checks for `Type[]` have been replaced with the new specialized `TypeListReferenceType`, leveraging interning via `TypeReferenceTable`. This requires an array-copy.
snazy
force-pushed
the
repro-indexes-2
branch
from
41b46fc to
43f5772
Compare
Member
|
I disagree we need to do this. To obtain stable output, the input must be stable. If Gradle users need reproducible Jandex, they should raise a bug with the Gradle plugin(s) to push input files to Jandex in stable order. |
Contributor
Author
|
Hey @Ladicek, could we at least discuss this a bit further? |
Member
|
I have no problem with discussing, but I believe I've said everything I could about this. To the best of my knowledge, given stable input, Jandex produces stable output. It is the Gradle plugin(s) that don't give stable input. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.