Skip to content

improve EquivalenceKeys caching #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ladicek merged 4 commits into from
Nov 27, 2025
+209 −74
Merged

improve EquivalenceKeys caching #623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f12c520
move back to modulo-by-bit-masking in ClassTypeEquivalenceKey
Ladicek Nov 27, 2025
baa35d2
improve the AnnotationOverlayBenchmark
Ladicek Nov 27, 2025
f377f90
improve EquivalenceKey equals() and hashCode()
Ladicek Nov 27, 2025
e5cf730
add ClassEquivalenceKey caching
Ladicek Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 79 additions & 7 deletions benchmarks/src/test/java/org/jboss/jandex/AnnotationOverlayBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Arrays;
import java.util.List;

import org.openjdk.jmh.annotations.Benchmark;
Expand All @@ -26,26 +26,43 @@ public class AnnotationOverlayBenchmark {

@Setup
public void setup() throws IOException {
index = Index.of(MyAnn1.class, MyAnn2.class, MyClass1.class, MyClass2.class, MyClass3.class,
MyClass4.class, MyClass5.class, MyClass6.class, MyClass7.class, MyClass8.class, MyClass9.class);
index = Index.of(MyAnn1.class, MyAnn2.class, MyAnn3.class, MyAnn4.class, MyClass1.class, MyClass2.class,
MyClass3.class, MyClass4.class, MyClass5.class, MyClass6.class, MyClass7.class, MyClass8.class,
MyClass9.class);

AnnotationTransformation transformation = new AnnotationTransformation() {
AnnotationTransformation classTransformation = new AnnotationTransformation() {
@Override
public boolean supports(AnnotationTarget.Kind kind) {
return kind == AnnotationTarget.Kind.CLASS;
}

@Override
public void apply(TransformationContext context) {
String name = context.declaration().asClass().name().toString();
String name = context.declaration().asClass().name().local();
if (name.endsWith("2") || name.endsWith("4")) {
context.removeAll();
} else if (name.endsWith("6") || name.endsWith("8")) {
context.add(MyAnn2.class);
context.add(MyAnn3.class);
}
}
};
overlay = AnnotationOverlay.builder(index, Collections.singleton(transformation)).build();
AnnotationTransformation methodTransformation = new AnnotationTransformation() {
@Override
public boolean supports(AnnotationTarget.Kind kind) {
return kind == AnnotationTarget.Kind.METHOD;
}

@Override
public void apply(TransformationContext context) {
String className = context.declaration().asMethod().declaringClass().name().local();
if (className.endsWith("2") || className.endsWith("4")) {
context.removeAll();
} else if (className.endsWith("6") || className.endsWith("8")) {
context.add(MyAnn4.class);
}
}
};
overlay = AnnotationOverlay.builder(index, Arrays.asList(classTransformation, methodTransformation)).build();
}

@Benchmark
Expand All @@ -54,18 +71,23 @@ public List<AnnotationInstance> noTransformation() {

ClassInfo clazz = index.getClassByName(MyClass1.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass3.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass5.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass7.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass9.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

return result;
}
Expand All @@ -76,9 +98,11 @@ public List<AnnotationInstance> removedAnnotations() {

ClassInfo clazz = index.getClassByName(MyClass2.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass4.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

return result;
}
Expand All @@ -89,9 +113,11 @@ public List<AnnotationInstance> addedAnnotations() {

ClassInfo clazz = index.getClassByName(MyClass6.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass8.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

return result;
}
Expand All @@ -102,15 +128,19 @@ public List<AnnotationInstance> addedAndRemovedAnnotations() {

ClassInfo clazz = index.getClassByName(MyClass2.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass4.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass6.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass8.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

return result;
}
Expand All @@ -121,30 +151,39 @@ public List<AnnotationInstance> allClasses() {

ClassInfo clazz = index.getClassByName(MyClass1.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass2.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass3.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass4.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass5.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass6.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass7.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass8.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

clazz = index.getClassByName(MyClass9.class);
result.addAll(overlay.annotations(clazz));
result.addAll(overlay.annotations(clazz.firstMethod("hello")));

return result;
}
Expand All @@ -155,39 +194,72 @@ public List<AnnotationInstance> allClasses() {
public @interface MyAnn2 {
}

public @interface MyAnn3 {
}

public @interface MyAnn4 {
}

@MyAnn1
public static class MyClass1 {
@MyAnn2
public void hello(int p1, String p2, List<Integer> p3) {
}
}

@MyAnn1
public static class MyClass2 {
@MyAnn2
public void hello(int p1, String p2, List<Integer> p3) {
}
}

@MyAnn1
public static class MyClass3 {
@MyAnn2
public void hello(int p1, String p2, List<Integer> p3) {
}
}

@MyAnn1
public static class MyClass4 {
@MyAnn2
public void hello(int p1, String p2, List<Integer> p3) {
}
}

@MyAnn1
public static class MyClass5 {
@MyAnn2
public void hello(int p1, String p2, List<Integer> p3) {
}
}

@MyAnn1
public static class MyClass6 {
@MyAnn2
public void hello(int p1, String p2, List<Integer> p3) {
}
}

@MyAnn1
public static class MyClass7 {
@MyAnn2
public void hello(int p1, String p2, List<Integer> p3) {
}
}

@MyAnn1
public static class MyClass8 {
@MyAnn2
public void hello(int p1, String p2, List<Integer> p3) {
}
}

@MyAnn1
public static class MyClass9 {
@MyAnn2
public void hello(int p1, String p2, List<Integer> p3) {
}
}
}
Loading