Add custom scalar support to client value formatter#2083
Add custom scalar support to client value formatter#2083sap-ali wants to merge 2 commits intosmallrye:mainfrom
Conversation
|
Can you do do a full build locally and commit again (so the formatter wont complain) |
|
I'm not sure how exactly this is intended to be used - AFAIR we don't have any CustomScalar support in the client library, so I can't imagine how this could be put to work - but maybe I'm missing something - could you demonstrate it with a higher level test or something? |
|
Maybe from another client (like JavaScript ?) |
|
No, this is a change in our client's code. |
|
O, sorry, I thought this was the server side. Ignore me :) |
|
I think the problem is that the |
|
BTW: I didn't want to say that it would not be useful to have this. |
6aa0d6e to
e6ffcf0
Compare
In the event that a request contains fields that are objects and within those objects there are field definitions with a type other than the primitives in the ValueFormatter, such as:
an IllegalStateException is thrown as below:
However, when the field is actually a custom scalar, the formatter should be able to support the serialization. This PR fixes the issue with the formatter.