Skip to content

Conversation

@jponge
Copy link
Member

@jponge jponge commented Sep 15, 2025

No description provided.

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.17%. Comparing base (629e16d) to head (67fe9de).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1956      +/-   ##
============================================
+ Coverage     89.04%   89.17%   +0.12%     
- Complexity     3066     3068       +2     
============================================
  Files           409      409              
  Lines         13064    13068       +4     
  Branches       1650     1650              
============================================
+ Hits          11633    11653      +20     
+ Misses          809      803       -6     
+ Partials        622      612      -10     
Files with missing lines Coverage Δ
...ye/mutiny/operators/multi/builders/NeverMulti.java 100.00% <ø> (ø)
...operators/uni/builders/UniCreateFromPublisher.java 97.29% <ø> (ø)

... and 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jponge jponge requested a review from Copilot September 15, 2025 21:16
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR contains various code polishing edits to improve code quality and modernize syntax. The changes include updating assertion method calls, modernizing string literals, and adding appropriate suppression annotations.

  • Updates deprecated assertion method calls to modern equivalents
  • Modernizes string concatenation to use text blocks
  • Adds unchecked suppression annotations where needed

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
UniJoinTest.java Adds unchecked suppression annotation to test class
UniOnEventTest.java Updates deprecated getRootCause() calls to rootCause()
MultiMergeTest.java Changes lowercase 'l' to uppercase 'L' for long literal
MultiCollectTest.java Modernizes instanceof pattern with pattern variable
AssertSubscriberTest.java Converts string concatenation to text blocks
UniOnFailureRetryTest.java Updates deprecated getCause() call to cause()
CompositeExceptionTest.java Updates deprecated getCause() calls to cause()
UniCreateFromPublisher.java Adds unchecked suppression annotation
NeverMulti.java Adds unchecked suppression annotation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jponge jponge merged commit da75a78 into smallrye:main Sep 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant