RabbitMQ: shared connections with context safety and config mismatch guard#3353
Closed
ozangunalp wants to merge 4 commits intosmallrye:mainfrom
Closed
RabbitMQ: shared connections with context safety and config mismatch guard#3353ozangunalp wants to merge 4 commits intosmallrye:mainfrom
ozangunalp wants to merge 4 commits intosmallrye:mainfrom
Conversation
ozangunalp
force-pushed
the
CassioGangrel/main
branch
from
922b20c to
187424e
Compare
Collaborator
Author
|
@CassioGangrel, sorry the PR was closed, I don't know what happened there. I pushed some tests and quick fixes to the branch. @cescoffier, if you'd have time to take a look, I am ok with this to be merged if the CI is green. |
ozangunalp
force-pushed
the
CassioGangrel/main
branch
from
187424e to
c19aa66
Compare
ozangunalp
force-pushed
the
CassioGangrel/main
branch
from
c19aa66 to
b5d2419
Compare
Collaborator
Author
|
CI green. Will follow up with another PR to improve RabbitMQ test coverage. |
Collaborator
Author
|
Closed with #3354 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clone of #3266