-
Notifications
You must be signed in to change notification settings - Fork 28
Feature consul tls discovery #1138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aureamunoz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you very much for this.
We need also some tests to validate this.
.../src/main/java/io/smallrye/stork/servicediscovery/consul/ConsulServiceDiscoveryProvider.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/smallrye/stork/servicediscovery/consul/ConsulServiceDiscoveryProvider.java
Outdated
Show resolved
Hide resolved
aureamunoz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Could you please add some test to validate this feature?
Sure, I will add the required tests. I will push the test changes in the next update. |
Background
We are using SmallRye Stork with Consul in production.
In our production environment, Consul is running with TLS enabled.
Currently, Stork Consul discovery does not support TLS configuration,
so we added SSL/TLS support and verified it in production.
What’s included
trust-store-path(CA file)trust-store-passwordkey-store-path(client certificate + private key)key-store-passwordverify-host(hostname verification)acl-token(Consul ACL authentication)Production status
✅ Already running in production.
Why this is useful
More and more users deploy Consul in secure (TLS) mode.
This change allows Stork to be used in secure enterprise environments.