Skip to content

Conversation

@chc0618
Copy link

@chc0618 chc0618 commented Dec 5, 2025

Background

We are using SmallRye Stork with Consul in production.
In our production environment, Consul is running with TLS enabled.

Currently, Stork Consul discovery does not support TLS configuration,
so we added SSL/TLS support and verified it in production.

What’s included

  • Support TLS when discovery services to Consul
  • Support configuration for:
    • trust-store-path (CA file)
    • trust-store-password
    • key-store-path (client certificate + private key)
    • key-store-password
    • verify-host (hostname verification)
    • acl-token (Consul ACL authentication)
  • Backward compatible (non-TLS users are not affected)

Production status

✅ Already running in production.

Why this is useful

More and more users deploy Consul in secure (TLS) mode.
This change allows Stork to be used in secure enterprise environments.

Copy link
Collaborator

@aureamunoz aureamunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thank you very much for this.
We need also some tests to validate this.

Copy link
Collaborator

@aureamunoz aureamunoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Could you please add some test to validate this feature?

@chc0618
Copy link
Author

chc0618 commented Dec 10, 2025

Thanks! Could you please add some test to validate this feature?

Sure, I will add the required tests.
Since this feature touches both Consul Discovery and Consul Registration, I plan to include:
1. Unit tests for the configuration parsing
2. Integration tests using a test Consul instance (with and without TLS)
3. Verification that the added attributes (ssl, trust-store, key-store, verify-host, acl-token) are correctly passed into the Vert.x HTTP client options.

I will push the test changes in the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants