Skip the Cavium root validity test until March 19th, 2026#938
Merged
Skip the Cavium root validity test until March 19th, 2026#938
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the skip condition for the Cavium root certificate validity test to extend the skip period until March 19, 2026. The change moves from a hardcoded Unix timestamp to a more readable RFC3339 date format and improves the skip message formatting.
Changes:
- Updated the test skip deadline from January 15, 2026 to March 19, 2026
- Replaced Unix timestamp with RFC3339 date parsing for better readability
- Enhanced skip message to use RFC1123 formatting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There's no new Cavium root certificate available yet. Bumping the date to skip this check with about 2 months for now. More info at https://www.marvell.com/products/security-solutions/nitrox-hs-adapters/liquidsecurity-certificate.html
hslatman
force-pushed
the
herman/bump-cavium-test-skip-date
branch
from
0dbd94e to
79419cb
Compare
smst-jeff
reviewed
Jan 20, 2026
smst-jeff
approved these changes
Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no new Cavium root certificate available yet. Bumping the date to skip this check with about 2 months for now.
More info at https://www.marvell.com/products/security-solutions/nitrox-hs-adapters/liquidsecurity-certificate.html