Add salt-length flag #211
Merged
Add salt-length flag #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows passing the --salt-length flag to the sign command. The salt length used to default to auto, which causes errors if we try to use a key in a KMS for TLS, as the Go standard library will default to rsa.PSSSaltLengthEqualsHash on RSA keys.
hslatman
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit allows passing the —-salt-length flag to the sign command. The salt length used to default to auto, but that causes errors if we try to use a key in a KMS for TLS, as the Go standard library will default to rsa.PSSSaltLengthEqualsHash on RSA keys.