fix(piral-modals): Modals weren’t stacking correctly on top of each other.#771
Closed
pranav-hsg wants to merge 1 commit intosmapiot:developfrom
Closed
fix(piral-modals): Modals weren’t stacking correctly on top of each other.#771pranav-hsg wants to merge 1 commit intosmapiot:developfrom
pranav-hsg wants to merge 1 commit intosmapiot:developfrom
Conversation
|
|
|
Error: Error while trying to collect info before merging hotfix/piral-modal-stack-order into develop. Error: Command failed: npx lerna run build:release
lerna notice cli v8.1.9
lerna info ci enabled
at genericNodeError (node:internal/errors:984:15)
at wrappedFn (node:internal/errors:538:14)
at ChildProcess.exithandler (node:child_process:422:12)
at ChildProcess.emit (node:events:518:28)
at maybeClose (node:internal/child_process:1105:16)
at ChildProcess._handle.onexit (node:internal/child_process:305:5)
Generated by @jsenv/file-size-impact during check-bundle-size#16882881443 on 309340b |
| ctx.dispatch((state) => ({ | ||
| ...state, | ||
| modals: prependItem(state.modals, dialog), | ||
| modals: appendItem(state.modals, dialog), |
Contributor
There was a problem hiding this comment.
To me that seems like a breaking change - right now the most recent is moved to the left, i.e., if the first (0 index) is picked this one is always in the front.
The actual representation is not done by piral-modals so I'd say this is rather an issue of documentation / implementation of the representation.
Contributor
|
Superseded by #773 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed issue where the most recently opened modal was not appearing on top and was instead appearing behind older modals.
Before :
After :