Add "fallbackLanguage" to piral-translate#806
Merged
FlorianRappl merged 1 commit intodevelopfrom Feb 25, 2026
Merged
Conversation
|
Manuel Römer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
manuelroemer
commented
Feb 25, 2026
File size impactImpact on file sizes when merging feature/fallback-language into develop. empty-piral (no impact)
minimal-piral (no impact)
sample-cross-fx (no impact)
sample-piral (+0.03%)
sample-piral-core (no impact)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request
For more information, see the
CONTRIBUTINGguide.Prerequisites
Please make sure you can check the following boxes:
Type(s) of Changes
Contribution Type
What types of changes does your code introduce? Put an
xin all the boxes that apply:Description
Adds a new
fallbackLanguagetopiral-translatewhich allows configuring a default language to be used for translations prior to the defaultfallbackfunction.The goal of this PR is to allow
translateAPI users to always show a translation with a conventional default language (e.g., english) that is always known to be available, even if the user's desired language is not yet implemented in a pilet.Currently, with the default
fallback, this is not (easily) possible because customfallbackfunctions do not have access to theLocalizer's internal API or theformatMessagefunction.Remarks
In principle, this PR is a suggestion - I am sure that there are other ways of implementing this. I am open to suggestions, this PR is just, in my eyes, the most straightforward way to do this.