Skip to content

Make sure to read all data from stdout and stderr #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarr merged 4 commits into from
Jul 7, 2025
Merged

Make sure to read all data from stdout and stderr #290

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
61d99cc
Read from channels until they are closed
smarr Jun 27, 2025
96d516b
Detect End Of File on stdout and stderr while reading
smarr Jun 27, 2025
213e33d
Need to call wait() to make sure we get the return code
smarr Jun 27, 2025
0951a2e
Use empty string to display a missing unit
smarr Jun 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 26 additions & 10 deletions rebench/subprocess_with_timeout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,24 +91,40 @@ def process_output(self, proc):
self.stdout_result = ""
self.stderr_result = ""

stdout_eof = False
stderr_eof = False

while True:
reads = [proc.stdout.fileno()]
if self._stderr == PIPE:
reads = []

if proc.stdout and not proc.stdout.closed and not stdout_eof:
reads.append(proc.stdout.fileno())
if (self._stderr == PIPE and
proc.stderr and
not proc.stderr.closed and
not stderr_eof):
reads.append(proc.stderr.fileno())
ret = select(reads, [], [])

if not reads:
proc.wait()
break

ret = select(reads, [], [], 0.1)
for file_no in ret[0]:
if file_no == proc.stdout.fileno():
read = output_as_str(proc.stdout.readline())
Copy link

Copilot AI Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider refactoring the duplicated logic for handling stdout and stderr reads into a helper function to improve maintainability and reduce code repetition.

Copilot uses AI. Check for mistakes.
sys.stdout.write(read)
self.stdout_result += read
if read == "":
stdout_eof = True
else:
sys.stdout.write(read)
self.stdout_result += read
if self._stderr == PIPE and file_no == proc.stderr.fileno():
read = output_as_str(proc.stderr.readline())
sys.stderr.write(read)
self.stderr_result += read

if proc.poll() is not None:
break
if read == "":
stderr_eof = True
else:
sys.stderr.write(read)
self.stderr_result += read
else:
stdout_r, stderr_r = proc.communicate()
self.stdout_result = output_as_str(stdout_r)
Expand Down