Skip to content

Conversation

david-sawatzke
Copy link
Collaborator

Fixes #7

I've ignored RGBW for now, as I haven't heard of any pixel order variations of them.

If I'm not completely mistaken, this doesn't introduce any breaking API changes

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/prerendered.rs:38

  • [nitpick] Consider using a consistent generic parameter name for pixel ordering throughout the code (e.g., use 'PO' in place of 'PIXELORDER' in the struct definition) to improve readability and reduce potential confusion.
pub struct Ws2812<'a, SPI, DEVICE = devices::Ws2812, PIXELORDER = pixel_order::GRB> {

src/lib.rs:77

  • [nitpick] Consider aligning the generic parameter naming with the implementations (e.g., using 'PO' consistently instead of 'PIXELORDER' in the struct definition) for better clarity.
pub struct Ws2812<SPI, DEVICE = devices::Ws2812, PIXELORDER = pixel_order::GRB> {

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RGB order vs. GRB order
1 participant