This repository was archived by the owner on Mar 14, 2025. It is now read-only.
Refactor MockCCIPRouter to support EVMExtraArgsV2 #1532
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrejrakic
requested review from
a team,
RayXpub,
elatoskinas and
makramkd
as code owners
RensR
approved these changes
Nov 18, 2024
0xsuryansh
previously approved these changes
Nov 18, 2024
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Contributor
|
This PR was closed because it has been stalled for 10 days with no activity. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Because of this check in the MockRouter contract https://github.com/smartcontractkit/ccip/blob/ccip-develop/contracts/src/v0.8/ccip/test/mocks/MockRouter.sol#L126 the local testing is failing when
EVMExtraArgsV2is used.Solution
Refactor
MockCCIPRouterto supportEVMExtraArgsV2.