This repository was archived by the owner on Mar 14, 2025. It is now read-only.
Fix reorg test flake #1542
Merged
Fix reorg test flake #1542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-gopalswami
requested review from
0xnogo,
asoliman92,
dimkouv,
makramkd,
mateusz-sekara,
rstout and
winder
makramkd
reviewed
Nov 18, 2024
AnieeG
approved these changes
Nov 19, 2024
asoliman92
approved these changes
Nov 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some weird reasons, the health check call in nodes doesn't show finality violated error consistently across all the nodes. Due to which this test TestSmokeCCIPReorgAboveFinalityAtDestination/Above_finality_reorg_in_destination_chain flakes often in CI.
Adjusting the expectation to have at least half of the nodes detects violation instead of every node.
CI Failure examples: https://github.com/smartcontractkit/chainlink/actions/runs/11894867899/job/33143516553
https://github.com/smartcontractkit/chainlink/actions/runs/11894232425/job/33141414438?pr=15282