Skip to content
This repository was archived by the owner on Mar 14, 2025. It is now read-only.

Conversation

@ma33r
Copy link
Collaborator

@ma33r ma33r commented Nov 19, 2024

What

  • Adds new Bitlayer Mainnet and Testnet OCR configs to CCIP

Why

  • This change supports an ongoing CCIP integration

@ma33r ma33r requested a review from a team as a code owner November 19, 2024 15:53
FinalityTagEnabled = false
FinalityDepth = 21 # confirmed with Bitlayer team and reccomended by docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/AboutFinality/#about-finality-at-stage-bitlayer-pos-bitlayer-mainnet-v1

[EVM.GasEstimator]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to try the Fee History estimator? if its easier to run another quick tests with FHE?
That would avoid the need to set all these Price values in the config

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had considered the Fee History estimator, but eth_FeeHistory is not supported by Bitlayer. They support a similar RPC method (eth_FeeHistory2), but this would require core code modification to support. (docs: https://docs.bitlayer.org/docs/Learn/BitlayerNetwork/Json-RPC/)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can still use the FHE & disable the EIP1559?

@ma33r ma33r requested a review from simsonraj November 19, 2024 17:17
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2025

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Jan 5, 2025
@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Jan 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants