This repository was archived by the owner on Mar 14, 2025. It is now read-only.
BCFR-1076 false unreachable RPC transition on rotation #1548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaidashenko
requested review from
0xAustinWang,
asoliman92,
dimkouv,
makramkd,
mateusz-sekara,
rstout and
winder
dhaidashenko
changed the base branch from
ccip-develop
to
release/2.17.0-ccip1.5
mateusz-sekara
approved these changes
Nov 27, 2024
DylanTinianov
approved these changes
Nov 27, 2024
mateusz-sekara
merged commit aa0f5ce
into
release/2.17.0-ccip1.5
137 of 138 checks passed
mateusz-sekara
deleted the
hotfix/BCFR-1076-false-unreachable-transiton-on-rotation
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In cases when lease duration > 0 MultiNode periodically rotates RPCs. As we have not marked the finalized head subscription as part of aliveLoopSub on RPC rotation, the subscription was closed, which caused RPC to transition to an unreachable state.
Solution
Mark finalized subscription as part of alive loop to avoid subscription termination on RPC rotation.