Skip to content
This repository was archived by the owner on Mar 14, 2025. It is now read-only.

Conversation

@flodesi
Copy link
Collaborator

@flodesi flodesi commented Jan 3, 2025

Motivation

As part of an ongoing integration effort, adding Sei testnet config to ccip

Solution

@flodesi flodesi requested a review from a team January 3, 2025 15:41
@flodesi flodesi requested a review from a team as a code owner January 3, 2025 15:41
ChainXLayer ChainType = "xlayer"
ChainZkEvm ChainType = "zkevm"
ChainZkSync ChainType = "zksync"
ChainSei ChainType = "sei"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically don't add a new chain type, unless it's type is needed to create some chain specific custom code.
For example, see this method that does custom code per chaintype: https://github.com/smartcontractkit/chainlink/blob/101fbbc75a76893d2ebe0c24fa61773876007d76/core/chains/evm/gas/chain_specific.go#L11-L60

If you haven't identified any custom code needed for Sei, then no need to create a new type here.
Atleast in this PR, I don't see any custom code added that acted on this new chaintype.

@prashantkumar1982
Copy link
Contributor

I haven't worked on the ccip branch before.
We always used to make changes to these files in the chainlink repo.
Do you know why you need to make these changes in the ccip branch?
Can you validate with the CCIP team, what is the right approach? I thought ccip team only used to merge from chainlink repo to ccip, not the other way.

@flodesi flodesi closed this Jan 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants