relay/config: config enhancements #79
Conversation
jmank88
force-pushed
the
CRE-361-configtest
branch
from
b3862c0 to
3153cd6
Compare
jmank88
force-pushed
the
CRE-361-configtest
branch
from
3153cd6 to
8749272
Compare
jmank88
force-pushed
the
CRE-361-configtest
branch
from
8749272 to
3e10fc5
Compare
relayer/txm/config.go
Outdated
| } else if c.ConfirmPollSecs != nil { | ||
| d, err2 := config.NewDuration(time.Duration(*c.ConfirmPollSecs) * time.Second) | ||
| if err2 != nil { | ||
| err = errors.Join(err, fmt.Errorf("ConfirmPollSecs must be a positive number: %w", err2)) | ||
| } | ||
| c.ConfirmPoll = &d | ||
| } |
There was a problem hiding this comment.
I would have rather used methods that return whichever is non-nil, but these field are being directly accessed right now.
jmank88
force-pushed
the
CRE-361-configtest
branch
from
3e10fc5 to
42b0e0b
Compare
jmank88
force-pushed
the
CRE-361-configtest
branch
from
42b0e0b to
c88b88f
Compare
jmank88
force-pushed
the
CRE-361-configtest
branch
from
c88b88f to
93d1fe1
Compare
jmank88
force-pushed
the
CRE-361-configtest
branch
from
93d1fe1 to
fc17aea
Compare
| Workflow *WorkflowConfig | ||
| } | ||
|
|
||
| type TxmConfig struct { |
There was a problem hiding this comment.
Moved (but aliased) to avoid a cycle.
jmank88
force-pushed
the
CRE-361-configtest
branch
from
fc17aea to
33a1528
Compare
jmank88
force-pushed
the
CRE-361-configtest
branch
from
33a1528 to
375b828
Compare
There was a problem hiding this comment.
Should this contain any more fields?
There was a problem hiding this comment.
We need to document each of these fields. I didn't see existing docs to copy from core or anywhere else in this repo. Is there somewhere else?
jmank88
force-pushed
the
CRE-361-configtest
branch
from
375b828 to
e65e50e
Compare
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
No CODEOWNERS file detected - @jmank88This repository doesn't contain a CODEOWNERS file. Please add one at one of the following paths:
If this repository is owned/used by a single team the default entry for a CODEOWNERS would be: For more information see: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners |
jmank88
force-pushed
the
CRE-361-configtest
branch
from
e65e50e to
68c491b
Compare
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
1 participant
https://smartcontract-it.atlassian.net/browse/CRE-361
Requires: