Skip to content

Conversation

@kylesmartin
Copy link
Contributor

@kylesmartin kylesmartin commented Dec 31, 2025

https://smartcontract-it.atlassian.net/browse/CCIP-8187

Requires pin to develop post-merge

kylesmartin and others added 30 commits December 16, 2025 14:05
# Conflicts:
#	ccv/chains/evm/gobindings/generated/latest/burn_mint_with_lock_release_flag_token_pool/burn_mint_with_lock_release_flag_token_pool.go
#	ccv/chains/evm/gobindings/generated/latest/onramp/onramp.go
#	ccv/chains/evm/gobindings/generated/latest/usdc_token_pool/usdc_token_pool.go
#	ccv/chains/evm/gobindings/generated/latest/usdc_token_pool_cctp_v2/usdc_token_pool_cctp_v2.go
#	ccv/chains/evm/gobindings/generated/latest/usdc_token_pool_proxy/usdc_token_pool_proxy.go
#	chains/evm/.gas-snapshot
#	chains/evm/contracts/pools/USDC/USDCTokenPool.sol
#	chains/evm/contracts/pools/USDC/USDCTokenPoolCCTPV2.sol
#	chains/evm/contracts/test/helpers/USDCTokenPoolCCTPV2Helper.sol
#	chains/evm/contracts/test/helpers/USDCTokenPoolHelper.sol
#	chains/evm/contracts/test/pools/BurnFromMintTokenPool/BurnFromMintTokenPoolSetup.t.sol
#	chains/evm/contracts/test/pools/BurnMintTokenPool/BurnMintTokenPool.lockOrBurn.t.sol
#	chains/evm/contracts/test/pools/BurnMintTokenPool/BurnMintTokenPool.releaseOrMint.t.sol
#	chains/evm/contracts/test/pools/BurnToAddressMintTokenPool/BurnToAddressMintTokenPoolSetup.t.sol
#	chains/evm/contracts/test/pools/BurnWithFromMintTokenPool/BurnWithFromMintTokenPool.lockOrBurn.t.sol
#	chains/evm/gobindings/generation/generated-wrapper-dependency-versions-do-not-edit.txt
# Conflicts:
#	ccv/chains/evm/gobindings/generated/latest/onramp/onramp.go
#	chains/evm/.gas-snapshot
#	chains/evm/gobindings/generation/generated-wrapper-dependency-versions-do-not-edit.txt
ChainSelector: input.ChainSelector,
Address: common.HexToAddress(input.TokenPoolAddress),
Args: input.FinalityValue,
Args: input.MinFinalityValue,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dont use this wording onchain, should be change this to refer to block depth instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because this is intended to support multiple chain families, and not all chains use block depth to identify finality. They may pass an ID here instead.

SupportingContracts []S
type CommitteeVerifierConfig[C any] struct {
// CommitteeVerifier is a set of addresses comprising the committee verifier system.
CommitteeVerifier []C
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is needed because we can have multiple live at the same time right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, EVM verifiers will have a resolver contract and all the active impls. It is up to the sequence implementation to error if it doesn't have all the contracts it needs to properly configure the environment.

Base automatically changed from usdc-cleanup to develop January 2, 2026 15:42
@kylesmartin kylesmartin marked this pull request as ready for review January 2, 2026 18:29
@kylesmartin kylesmartin requested review from a team as code owners January 2, 2026 18:29
@kylesmartin kylesmartin requested a review from RensR January 2, 2026 18:30
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

Metric CCIP-8187-pt-2 develop
Coverage 69.4% 69.1%

@RensR RensR enabled auto-merge (squash) January 5, 2026 11:59
@RensR RensR merged commit e1abf82 into develop Jan 5, 2026
27 checks passed
@RensR RensR deleted the CCIP-8187-pt-2 branch January 5, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants