-
Notifications
You must be signed in to change notification settings - Fork 24
[CCIP 8187] CCTP deployment tooling #1523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # ccv/chains/evm/gobindings/generated/latest/burn_mint_with_lock_release_flag_token_pool/burn_mint_with_lock_release_flag_token_pool.go # ccv/chains/evm/gobindings/generated/latest/onramp/onramp.go # ccv/chains/evm/gobindings/generated/latest/usdc_token_pool/usdc_token_pool.go # ccv/chains/evm/gobindings/generated/latest/usdc_token_pool_cctp_v2/usdc_token_pool_cctp_v2.go # ccv/chains/evm/gobindings/generated/latest/usdc_token_pool_proxy/usdc_token_pool_proxy.go # chains/evm/.gas-snapshot # chains/evm/contracts/pools/USDC/USDCTokenPool.sol # chains/evm/contracts/pools/USDC/USDCTokenPoolCCTPV2.sol # chains/evm/contracts/test/helpers/USDCTokenPoolCCTPV2Helper.sol # chains/evm/contracts/test/helpers/USDCTokenPoolHelper.sol # chains/evm/contracts/test/pools/BurnFromMintTokenPool/BurnFromMintTokenPoolSetup.t.sol # chains/evm/contracts/test/pools/BurnMintTokenPool/BurnMintTokenPool.lockOrBurn.t.sol # chains/evm/contracts/test/pools/BurnMintTokenPool/BurnMintTokenPool.releaseOrMint.t.sol # chains/evm/contracts/test/pools/BurnToAddressMintTokenPool/BurnToAddressMintTokenPoolSetup.t.sol # chains/evm/contracts/test/pools/BurnWithFromMintTokenPool/BurnWithFromMintTokenPool.lockOrBurn.t.sol # chains/evm/gobindings/generation/generated-wrapper-dependency-versions-do-not-edit.txt
# Conflicts: # ccv/chains/evm/gobindings/generated/latest/onramp/onramp.go # chains/evm/.gas-snapshot # chains/evm/gobindings/generation/generated-wrapper-dependency-versions-do-not-edit.txt
| ChainSelector: input.ChainSelector, | ||
| Address: common.HexToAddress(input.TokenPoolAddress), | ||
| Args: input.FinalityValue, | ||
| Args: input.MinFinalityValue, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We dont use this wording onchain, should be change this to refer to block depth instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No because this is intended to support multiple chain families, and not all chains use block depth to identify finality. They may pass an ID here instead.
ccv/chains/evm/deployment/v1_7_0/sequences/deploy_verifier_resolver_via_create2.go
Show resolved
Hide resolved
| SupportingContracts []S | ||
| type CommitteeVerifierConfig[C any] struct { | ||
| // CommitteeVerifier is a set of addresses comprising the committee verifier system. | ||
| CommitteeVerifier []C |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is needed because we can have multiple live at the same time right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, EVM verifiers will have a resolver contract and all the active impls. It is up to the sequence implementation to error if it doesn't have all the contracts it needs to properly configure the environment.
ccv/chains/evm/deployment/v1_7_0/sequences/cctp/deploy_cctp_chain.go
Outdated
Show resolved
Hide resolved
ccv/chains/evm/deployment/v1_7_0/sequences/cctp/deploy_cctp_chain.go
Outdated
Show resolved
Hide resolved
ccv/chains/evm/deployment/v1_7_0/sequences/cctp/deploy_cctp_chain.go
Outdated
Show resolved
Hide resolved
|
https://smartcontract-it.atlassian.net/browse/CCIP-8187
Requires pin to develop post-merge