Skip to content

replace ambigous ugorji lib #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
skudasov wants to merge 2 commits into
base: main
Choose a base branch
from
Open

replace ambigous ugorji lib #1527

skudasov wants to merge 2 commits into from

Conversation

@skudasov
Copy link
Collaborator

@skudasov skudasov commented Jan 5, 2026

Fixes ambiguous dependency

fahrenheit@MB-W5XFWRRYTR devenv % just cli
pushd cmd/ccip > /dev/null && go install -ldflags="-X main.Version=1.0.0" . && popd > /dev/null
../../../../../go/pkg/mod/github.com/smartcontractkit/[email protected]/pkg/types/blocks/internal_types_codecgen.go:12:2: ambiguous import: found package github.com/ugorji/go/codec in multiple modules:
	github.com/ugorji/go v1.1.4 (/Users/fahrenheit/go/pkg/mod/github.com/ugorji/[email protected]/codec)
	github.com/ugorji/go/codec v1.2.12 (/Users/fahrenheit/go/pkg/mod/github.com/ugorji/go/[email protected])
error: Recipe `cli` failed on line 36 with exit code 1

@skudasov skudasov requested a review from a team as a code owner January 5, 2026 12:39
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

👋 skudasov, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@tt-cll tt-cll enabled auto-merge January 5, 2026 13:22
@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Metric fix-ugorji-dep-replace main
Coverage 70.3% 69.7%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tt-cll tt-cll tt-cll approved these changes

@winder winder Awaiting requested review from winder winder was automatically assigned from smartcontractkit/ccip-offchain

@makramkd makramkd Awaiting requested review from makramkd makramkd was automatically assigned from smartcontractkit/ccip-offchain

@agusaldasoro agusaldasoro Awaiting requested review from agusaldasoro agusaldasoro was automatically assigned from smartcontractkit/ccip-offchain

@mateusz-sekara mateusz-sekara Awaiting requested review from mateusz-sekara mateusz-sekara was automatically assigned from smartcontractkit/ccip-offchain

@0xAustinWang 0xAustinWang Awaiting requested review from 0xAustinWang 0xAustinWang was automatically assigned from smartcontractkit/ccip-offchain

@chris-de-leon-cll chris-de-leon-cll Awaiting requested review from chris-de-leon-cll chris-de-leon-cll was automatically assigned from smartcontractkit/ccip-offchain

@b-gopalswami b-gopalswami Awaiting requested review from b-gopalswami b-gopalswami was automatically assigned from smartcontractkit/ccip-offchain

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@skudasov @tt-cll