Skip to content

Conversation

@pavel-raykov
Copy link
Contributor

No description provided.

@pavel-raykov pavel-raykov changed the title [CRE-491] Used moved consts from chainlink-common. [CRE-491] Used moved ccip consts from chainlink-common. Jan 14, 2026
@pavel-raykov pavel-raykov force-pushed the move-consts branch 3 times, most recently from 9ccfc89 to 65103a8 Compare January 14, 2026 16:07
@pavel-raykov pavel-raykov force-pushed the move-consts branch 2 times, most recently from 65d7ac2 to c341dd7 Compare January 19, 2026 15:09
@pavel-raykov pavel-raykov marked this pull request as ready for review January 19, 2026 15:21
@pavel-raykov pavel-raykov requested review from a team as code owners January 19, 2026 15:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates CCIP constants from a local package (chainlink-ccip/pkg/consts) to a shared package in chainlink-common (chainlink-common/pkg/types/ccip/consts). This standardizes the location of CCIP constants across the codebase by moving them to the common library.

Changes:

  • Updated import statements across all files to reference the new constants package location
  • Reorganized import ordering to follow Go conventions (standard library, external packages, internal packages)

Reviewed changes

Copilot reviewed 45 out of 45 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/reader/usdc_reader_test.go Updated import to use chainlink-common consts package
pkg/reader/usdc_reader_solana_accessor.go Updated import and removed empty line between imports
pkg/reader/usdc_reader_solana.go Updated import and reorganized import grouping
pkg/reader/usdc_reader_evm.go Updated import and reorganized import grouping
pkg/reader/usdc_reader.go Updated import and removed empty line
pkg/reader/rmn_home_poller_test.go Updated import and reorganized import order
pkg/reader/rmn_home_poller.go Updated import and reorganized import grouping
pkg/reader/config_poller_test.go Updated import to use chainlink-common consts package
pkg/reader/config_poller.go Updated import and reorganized import grouping
pkg/reader/ccip_test.go Updated import and reorganized import order
pkg/reader/ccip.go Updated import and reorganized import grouping
pkg/contractreader/extended_test.go Updated import and reorganized import order
pkg/contractreader/extended.go Updated import and removed empty line
pkg/chainaccessor/default_price_reader_test.go Updated import and removed empty line
pkg/chainaccessor/default_price_reader.go Updated import and removed empty line
pkg/chainaccessor/default_accessor_test.go Updated import to use chainlink-common consts package
pkg/chainaccessor/default_accessor.go Updated import and removed empty line
pkg/chainaccessor/config_processors.go Updated import and removed empty line
internal/reader/home_chain_test.go Updated import and removed empty line
internal/reader/home_chain.go Updated import and reorganized import grouping
internal/plugincommon/discovery/processor_test.go Updated import to use chainlink-common consts package
internal/plugincommon/discovery/processor.go Updated import and removed empty line
execute/tokendata/usdc/usdc_int_test.go Updated import to use chainlink-common consts package
execute/test_utils.go Updated import to use chainlink-common consts package
execute/plugin_test.go Updated import to use chainlink-common consts package
execute/observation_test.go Updated import and reorganized import grouping
execute/observation.go Updated import and removed empty line
execute/factory_test.go Updated import to use chainlink-common consts package
devenv/chainimpl/ccip-solana/impl.go Updated import to use chainlink-common consts package
commit/tokenprice/processor_test.go Updated import and removed empty lines
commit/tokenprice/processor.go Updated import and reorganized import grouping
commit/tokenprice/observation.go Updated import and reorganized import grouping
commit/report.go Updated import and reorganized import grouping
commit/plugin_roledon_e2e_test.go Updated import and removed empty lines
commit/plugin_old.go Updated import and removed empty line
commit/plugin_e2e_test.go Updated import to use chainlink-common consts package
commit/plugin.go Updated import and removed empty line
commit/merkleroot/query_test.go Updated import and reorganized import grouping
commit/merkleroot/query.go Updated import and removed empty line
commit/merkleroot/observation.go Updated import and removed empty line
commit/factory.go Updated import and reorganized import grouping
commit/chainfee/outcome_test.go Updated import and reorganized import order
commit/chainfee/outcome.go Updated import and reorganized import grouping
commit/chainfee/observation.go Updated import and reorganized import grouping
chains/solana/utils/common/event.go Updated import to use chainlink-common consts package

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

Metric move-consts main
Coverage 70.3% 69.6%

@pavel-raykov pavel-raykov added this pull request to the merge queue Jan 19, 2026
Merged via the queue into main with commit 4992415 Jan 19, 2026
102 of 107 checks passed
@pavel-raykov pavel-raykov deleted the move-consts branch January 19, 2026 16:33
@pavel-raykov pavel-raykov restored the move-consts branch January 20, 2026 18:39
@pavel-raykov pavel-raykov deleted the move-consts branch January 20, 2026 18:41
@pavel-raykov pavel-raykov restored the move-consts branch January 20, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants