-
Notifications
You must be signed in to change notification settings - Fork 28
[CRE-491] Used moved ccip consts from chainlink-common. #1562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9ccfc89 to
65103a8
Compare
65d7ac2 to
c341dd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates CCIP constants from a local package (chainlink-ccip/pkg/consts) to a shared package in chainlink-common (chainlink-common/pkg/types/ccip/consts). This standardizes the location of CCIP constants across the codebase by moving them to the common library.
Changes:
- Updated import statements across all files to reference the new constants package location
- Reorganized import ordering to follow Go conventions (standard library, external packages, internal packages)
Reviewed changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/reader/usdc_reader_test.go | Updated import to use chainlink-common consts package |
| pkg/reader/usdc_reader_solana_accessor.go | Updated import and removed empty line between imports |
| pkg/reader/usdc_reader_solana.go | Updated import and reorganized import grouping |
| pkg/reader/usdc_reader_evm.go | Updated import and reorganized import grouping |
| pkg/reader/usdc_reader.go | Updated import and removed empty line |
| pkg/reader/rmn_home_poller_test.go | Updated import and reorganized import order |
| pkg/reader/rmn_home_poller.go | Updated import and reorganized import grouping |
| pkg/reader/config_poller_test.go | Updated import to use chainlink-common consts package |
| pkg/reader/config_poller.go | Updated import and reorganized import grouping |
| pkg/reader/ccip_test.go | Updated import and reorganized import order |
| pkg/reader/ccip.go | Updated import and reorganized import grouping |
| pkg/contractreader/extended_test.go | Updated import and reorganized import order |
| pkg/contractreader/extended.go | Updated import and removed empty line |
| pkg/chainaccessor/default_price_reader_test.go | Updated import and removed empty line |
| pkg/chainaccessor/default_price_reader.go | Updated import and removed empty line |
| pkg/chainaccessor/default_accessor_test.go | Updated import to use chainlink-common consts package |
| pkg/chainaccessor/default_accessor.go | Updated import and removed empty line |
| pkg/chainaccessor/config_processors.go | Updated import and removed empty line |
| internal/reader/home_chain_test.go | Updated import and removed empty line |
| internal/reader/home_chain.go | Updated import and reorganized import grouping |
| internal/plugincommon/discovery/processor_test.go | Updated import to use chainlink-common consts package |
| internal/plugincommon/discovery/processor.go | Updated import and removed empty line |
| execute/tokendata/usdc/usdc_int_test.go | Updated import to use chainlink-common consts package |
| execute/test_utils.go | Updated import to use chainlink-common consts package |
| execute/plugin_test.go | Updated import to use chainlink-common consts package |
| execute/observation_test.go | Updated import and reorganized import grouping |
| execute/observation.go | Updated import and removed empty line |
| execute/factory_test.go | Updated import to use chainlink-common consts package |
| devenv/chainimpl/ccip-solana/impl.go | Updated import to use chainlink-common consts package |
| commit/tokenprice/processor_test.go | Updated import and removed empty lines |
| commit/tokenprice/processor.go | Updated import and reorganized import grouping |
| commit/tokenprice/observation.go | Updated import and reorganized import grouping |
| commit/report.go | Updated import and reorganized import grouping |
| commit/plugin_roledon_e2e_test.go | Updated import and removed empty lines |
| commit/plugin_old.go | Updated import and removed empty line |
| commit/plugin_e2e_test.go | Updated import to use chainlink-common consts package |
| commit/plugin.go | Updated import and removed empty line |
| commit/merkleroot/query_test.go | Updated import and reorganized import grouping |
| commit/merkleroot/query.go | Updated import and removed empty line |
| commit/merkleroot/observation.go | Updated import and removed empty line |
| commit/factory.go | Updated import and reorganized import grouping |
| commit/chainfee/outcome_test.go | Updated import and reorganized import order |
| commit/chainfee/outcome.go | Updated import and reorganized import grouping |
| commit/chainfee/observation.go | Updated import and reorganized import grouping |
| chains/solana/utils/common/event.go | Updated import to use chainlink-common consts package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
No description provided.