[CRE-491] Used moved ccip consts from chainlink-common.#1562
Merged
pavel-raykov merged 1 commit intomainfrom Jan 19, 2026
Merged
[CRE-491] Used moved ccip consts from chainlink-common.#1562pavel-raykov merged 1 commit intomainfrom
pavel-raykov merged 1 commit intomainfrom
Conversation
9ccfc89 to
65103a8
Compare
65d7ac2 to
c341dd7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates CCIP constants from a local package (chainlink-ccip/pkg/consts) to a shared package in chainlink-common (chainlink-common/pkg/types/ccip/consts). This standardizes the location of CCIP constants across the codebase by moving them to the common library.
Changes:
- Updated import statements across all files to reference the new constants package location
- Reorganized import ordering to follow Go conventions (standard library, external packages, internal packages)
Reviewed changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/reader/usdc_reader_test.go | Updated import to use chainlink-common consts package |
| pkg/reader/usdc_reader_solana_accessor.go | Updated import and removed empty line between imports |
| pkg/reader/usdc_reader_solana.go | Updated import and reorganized import grouping |
| pkg/reader/usdc_reader_evm.go | Updated import and reorganized import grouping |
| pkg/reader/usdc_reader.go | Updated import and removed empty line |
| pkg/reader/rmn_home_poller_test.go | Updated import and reorganized import order |
| pkg/reader/rmn_home_poller.go | Updated import and reorganized import grouping |
| pkg/reader/config_poller_test.go | Updated import to use chainlink-common consts package |
| pkg/reader/config_poller.go | Updated import and reorganized import grouping |
| pkg/reader/ccip_test.go | Updated import and reorganized import order |
| pkg/reader/ccip.go | Updated import and reorganized import grouping |
| pkg/contractreader/extended_test.go | Updated import and reorganized import order |
| pkg/contractreader/extended.go | Updated import and removed empty line |
| pkg/chainaccessor/default_price_reader_test.go | Updated import and removed empty line |
| pkg/chainaccessor/default_price_reader.go | Updated import and removed empty line |
| pkg/chainaccessor/default_accessor_test.go | Updated import to use chainlink-common consts package |
| pkg/chainaccessor/default_accessor.go | Updated import and removed empty line |
| pkg/chainaccessor/config_processors.go | Updated import and removed empty line |
| internal/reader/home_chain_test.go | Updated import and removed empty line |
| internal/reader/home_chain.go | Updated import and reorganized import grouping |
| internal/plugincommon/discovery/processor_test.go | Updated import to use chainlink-common consts package |
| internal/plugincommon/discovery/processor.go | Updated import and removed empty line |
| execute/tokendata/usdc/usdc_int_test.go | Updated import to use chainlink-common consts package |
| execute/test_utils.go | Updated import to use chainlink-common consts package |
| execute/plugin_test.go | Updated import to use chainlink-common consts package |
| execute/observation_test.go | Updated import and reorganized import grouping |
| execute/observation.go | Updated import and removed empty line |
| execute/factory_test.go | Updated import to use chainlink-common consts package |
| devenv/chainimpl/ccip-solana/impl.go | Updated import to use chainlink-common consts package |
| commit/tokenprice/processor_test.go | Updated import and removed empty lines |
| commit/tokenprice/processor.go | Updated import and reorganized import grouping |
| commit/tokenprice/observation.go | Updated import and reorganized import grouping |
| commit/report.go | Updated import and reorganized import grouping |
| commit/plugin_roledon_e2e_test.go | Updated import and removed empty lines |
| commit/plugin_old.go | Updated import and removed empty line |
| commit/plugin_e2e_test.go | Updated import to use chainlink-common consts package |
| commit/plugin.go | Updated import and removed empty line |
| commit/merkleroot/query_test.go | Updated import and reorganized import grouping |
| commit/merkleroot/query.go | Updated import and removed empty line |
| commit/merkleroot/observation.go | Updated import and removed empty line |
| commit/factory.go | Updated import and reorganized import grouping |
| commit/chainfee/outcome_test.go | Updated import and reorganized import order |
| commit/chainfee/outcome.go | Updated import and reorganized import grouping |
| commit/chainfee/observation.go | Updated import and reorganized import grouping |
| chains/solana/utils/common/event.go | Updated import to use chainlink-common consts package |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KodeyThomas
approved these changes
Jan 19, 2026
RensR
approved these changes
Jan 19, 2026
|
RensR
added a commit
that referenced
this pull request
Feb 2, 2026
* Bump Go deps and fix NPM deps (#1570) * carpenter * Delete package-lock.json * rm unused override * move to dev deps * [CRE-491] Bump common and other deps (#1576) * gomods. * gomods. * Minor. * Code (#1562) * Add more clear instructions to seqno consensus failure log (#1572) * CCIP-8527: Adding operations and sequences for token governor contract (#1579) * CCIP-8527: Adding operations and sequences for token governor contract * review comment * review commnet -ai * [CRE-491] Delete unused consts pkg (instead we use its copy from common) (#1577) * Minor. * Minor. * Minor. * chore: trigger pipeline * chore: trigger pipeline * Minor. * chore: trigger pipeline * Minor. * Minor. * Minor. * chore: trigger pipeline * Add GasLimit to commit offchain config (#1598) * Add GasLimit to commit offchain plugin * rename to EVMGasLimit * error on the commit plugin if rmn is enabled (#1587) * error on the commit plugin if rmn is enabled * fix tests * update test * Ccip-8991 one environment for forked and local chains (#1595) * one environment * updates * Ccip-8552 Adding metadata as onchain output (#1601) * adding metadata as onchain output * matching with develop * handle conflicts * Clean up lots of dead/deprecated CCIPReader code (#1573) * Clean up lots of dead CCIPReader code * lint and regen * fix processor test * lint and fix more tests * make generate * update discovery tests * Migrate devenv to test adapters (#1589) * Migrate devenv to test adapters * fixes: EVM tests and Solana->EVM pass again * fix gas limits * Fix solana->evm and evm->solana * Revert change * goimports -w -local github.com/smartcontractkit/chainlink-ccip . * Remove local replaces * go mod fixup * fix lint * Deduplicate code * Fix lints * Fix some of the solana lints * cleanup * Remove unnecessary generics * feat: implement token api for evm 1.6 (#1588) * feat: implement token api for evm 1.6 * feat: add integration test, refactor evm token adapter impl, fix token pool qualifier bug * chore: reword comment * fix: do not use token symbol for token pool qualifier * chore: add more EVM token expansion checks * fix: gomodtidy * chore: add more comments and refactor GetToken calls * Refactor go bindings and deployment evm (#1578) * Refactor go bindings and deployment evm * fix ping pong * Fix tests * Fix mock Import * review comments * Replace factory bnmerc20 with bnmerc20 * more test has factory bnmerc20 * Remove option to deploy factory_burn_mint_erc20 directly * lint fix * make generate * go sum * Fix mocks * Fix imports * Use correct token for testing * Modify owner * Test --------- Co-authored-by: Balamurali Gopalswami <balamurali.gopalswami@smartcontract.com> * bump cl-ton version and update tooling adapter (#1604) * bump cl-ton version and update tooling adapter * bump dependency for devenv * bump mod * update modgraph --------- Co-authored-by: Jonghyeon Park <jadepark.dev@gmail.com> * bump mcms, fix ref (#1609) --------- Co-authored-by: pavel-raykov <165708424+pavel-raykov@users.noreply.github.com> Co-authored-by: Oliver Townsend <133903322+ogtownsend@users.noreply.github.com> Co-authored-by: Balamurali Gopalswami <167726375+b-gopalswami@users.noreply.github.com> Co-authored-by: Abdelrahman Soliman (Boda) <2677789+asoliman92@users.noreply.github.com> Co-authored-by: Austin <107539019+0xAustinWang@users.noreply.github.com> Co-authored-by: Anindita Ghosh <88458927+AnieeG@users.noreply.github.com> Co-authored-by: Blaž Hrastnik <blaz@mxxn.io> Co-authored-by: Chris De Leon <147140544+chris-de-leon-cll@users.noreply.github.com> Co-authored-by: Agustina Aldasoro <agusaldasoro@users.noreply.github.com> Co-authored-by: Balamurali Gopalswami <balamurali.gopalswami@smartcontract.com> Co-authored-by: Joe Huang <joe.huang@smartcontract.com> Co-authored-by: Jonghyeon Park <jadepark.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.