Skip to content

make NetworkFeeUSDCents u16#1590

Open
RensR wants to merge 2 commits intomainfrom
NetworkFeeUSDCents-uint16
Open

make NetworkFeeUSDCents u16#1590
RensR wants to merge 2 commits intomainfrom
NetworkFeeUSDCents-uint16

Conversation

@RensR
Copy link
Collaborator

@RensR RensR commented Jan 22, 2026

1.7 makes this value uint16, meaning we can change the source to uint16 and cast to uint32 in legacy contract config.

Fixes failing CI on the develop branch relating to TON expecting u32

core ref: d735a58b8a90eb705759661d9aa867c079980e02

@RensR RensR marked this pull request as ready for review February 2, 2026 12:32
@RensR RensR requested review from a team as code owners February 2, 2026 12:32
Copilot AI review requested due to automatic review settings February 2, 2026 12:32
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the NetworkFeeUSDCents field type from uint32 to uint16 in the FeeQuoterDestChainConfig struct to align with version 1.7 specifications. The change addresses failing CI on the develop branch related to TON expecting u32.

Changes:

  • Changed NetworkFeeUSDCents field type from uint32 to uint16 in the core config struct
  • Added explicit uint32 casts when translating to legacy contract configurations
  • Reorganized import statements for better grouping

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
deployment/lanes/lane_update.go Updated NetworkFeeUSDCents field type from uint32 to uint16 in FeeQuoterDestChainConfig struct
chains/solana/deployment/v1_6_0/sequences/connect_chains.go Added uint32 cast for NetworkFeeUSDCents in legacy contract translation and reorganized imports
chains/evm/deployment/v1_6_0/sequences/update_lanes.go Added uint32 cast for NetworkFeeUSDCents in legacy contract translation and reorganized imports

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@RensR RensR added this pull request to the merge queue Feb 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 2, 2026
@RensR RensR added this pull request to the merge queue Feb 2, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 2, 2026
@RensR RensR added this pull request to the merge queue Feb 2, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 2, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 2, 2026
@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Metric NetworkFeeUSDCents-uint16 main
Coverage 69.8% 69.5%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants