Conversation
agusaldasoro
reviewed
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates lane-connection logic across CCIP 1.6 and 2.0 by moving configuration onto the deployment/lanes ConnectChains flow, wiring EVM lane adapters into the shared registry, and removing the prior v1_7_0 “ConfigureChainsForLanes” changeset/adapter plumbing.
Changes:
- Introduces v2-oriented lane config fields in
deployment/lanesand updates ConnectChains to populate/resolve them. - Refactors EVM lane configuration sequences to
ConfigureLaneLegAsSource/ConfigureLaneLegAsDestand updates related tests to use the new lanes types. - Updates module wiring (
replacedirectives / go.sum) to use local CCIP + CCV EVM modules consistently.
Reviewed changes
Copilot reviewed 21 out of 25 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| integration-tests/go.mod | Adds local replace for ccv/chains/evm module. |
| integration-tests/go.sum | Removes now-unneeded module checksum entries after replace changes. |
| devenv/go.mod | Enables local replace for root + CCV EVM modules (and deployment paths). |
| devenv/go.sum | Removes no-longer-referenced module checksum entries. |
| deployment/v1_7_0/changesets/configure_chains_for_lanes.go | Deletes legacy v1_7_0 lanes changeset implementation. |
| deployment/v1_7_0/changesets/configure_chains_for_lanes_test.go | Deletes legacy tests for the removed changeset. |
| deployment/v1_7_0/adapters/chain_family.go | Deletes legacy chain-family registry/types used by removed changeset. |
| deployment/utils/common.go | Adds Version_2_0_0 semver constant for version gating. |
| deployment/lanes/lane_update.go | Expands ChainDefinition and related types to include 2.0 lane config fields. |
| deployment/lanes/connect_chains.go | Updates ConnectChains flow to populate v2 fields and persist sequence metadata. |
| chains/evm/deployment/go.mod | Adds local replace for root module to keep builds consistent. |
| chains/evm/deployment/go.sum | Removes no-longer-needed module checksum entries after replace changes. |
| ccv/chains/evm/deployment/go.mod | Adds local replaces for CCV EVM module and root module, plus deployment paths. |
| ccv/chains/evm/deployment/go.sum | Removes module checksum entries no longer needed with local replaces. |
| ccv/chains/evm/deployment/v1_7_0/testsetup/testsetup.go | Switches config builders to deployment/lanes types and derives family selector. |
| ccv/chains/evm/deployment/v1_7_0/sequences/configure_committee_verifier_for_lanes.go | Swaps config types from v1_7_0 adapters to deployment/lanes. |
| ccv/chains/evm/deployment/v1_7_0/sequences/configure_committee_verifier_for_lanes_test.go | Updates tests to use deployment/lanes types. |
| ccv/chains/evm/deployment/v1_7_0/sequences/configure_chain_for_lanes.go | Replaces ConfigureChainForLanes with leg-based source/dest sequences and new config conversions. |
| ccv/chains/evm/deployment/v1_7_0/sequences/configure_chain_for_lanes_test.go | Updates test to exercise new leg-based sequences. |
| ccv/chains/evm/deployment/v1_7_0/operations/executor/executor.go | Switches executor config type dependency to deployment/lanes. |
| ccv/chains/evm/deployment/v1_7_0/adapters/lanemigrator_test.go | Uses lanes.ConnectChains rather than removed ConfigureChainsForLanes changeset. |
| ccv/chains/evm/deployment/v1_7_0/adapters/lanemigrator.go | Updates comment to reference ConnectChains. |
| ccv/chains/evm/deployment/v1_7_0/adapters/init.go | Registers EVM lane adapter into lanes.GetLaneAdapterRegistry(). |
| ccv/chains/evm/deployment/v1_7_0/adapters/chain_family_test.go | Migrates adapter test to lanes.ConnectChains + new ChainDefinition builder. |
| ccv/chains/evm/deployment/v1_7_0/adapters/chain_family.go | Implements the lanes.LaneAdapter interface and adds Get*Address helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ccv/chains/evm/deployment/v1_7_0/sequences/configure_chain_for_lanes.go
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
kylesmartin
reviewed
Mar 10, 2026
ccv/chains/evm/deployment/v1_7_0/sequences/configure_chain_for_lanes.go
Outdated
Show resolved
Hide resolved
kylesmartin
previously approved these changes
Mar 13, 2026
agusaldasoro
previously approved these changes
Mar 13, 2026
| @@ -1,182 +0,0 @@ | |||
| package adapters | |||
Contributor
There was a problem hiding this comment.
Should we remove the entire deployment/v1_7_0 folder?
|
carte7000
approved these changes
Mar 13, 2026
kylesmartin
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.