Skip to content

Commit 624fe53

Browse files
committed
Add event timeout to protos
1 parent ea7bf83 commit 624fe53

File tree

4 files changed

+53
-36
lines changed

4 files changed

+53
-36
lines changed

pkg/capabilities/capabilities.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -552,6 +552,7 @@ func MustNewRemoteCapabilityInfo(
552552
const (
553553
DefaultRegistrationRefresh = 30 * time.Second
554554
DefaultRegistrationExpiry = 2 * time.Minute
555+
DefaultEventTimeout = 2 * time.Minute // TODO: determine best value
555556
DefaultMessageExpiry = 2 * time.Minute
556557
DefaultBatchSize = 100
557558
DefaultBatchCollectionPeriod = 100 * time.Millisecond
@@ -562,6 +563,7 @@ const (
562563
type RemoteTriggerConfig struct {
563564
RegistrationRefresh time.Duration
564565
RegistrationExpiry time.Duration
566+
EventTimeout time.Duration
565567
MinResponsesToAggregate uint32
566568
MessageExpiry time.Duration
567569
MaxBatchSize uint32
@@ -595,6 +597,9 @@ func (c *RemoteTriggerConfig) ApplyDefaults() {
595597
if c.RegistrationExpiry == 0 {
596598
c.RegistrationExpiry = DefaultRegistrationExpiry
597599
}
600+
if c.EventTimeout == 0 {
601+
c.EventTimeout = DefaultEventTimeout
602+
}
598603
if c.MessageExpiry == 0 {
599604
c.MessageExpiry = DefaultMessageExpiry
600605
}

pkg/capabilities/pb/registry.pb.go

Lines changed: 42 additions & 32 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/capabilities/pb/registry.proto

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,11 @@ import "google/protobuf/duration.proto";
1010
message RemoteTriggerConfig {
1111
google.protobuf.Duration registrationRefresh = 1;
1212
google.protobuf.Duration registrationExpiry = 2;
13-
uint32 minResponsesToAggregate = 3;
14-
google.protobuf.Duration messageExpiry = 4;
15-
uint32 maxBatchSize = 5;
16-
google.protobuf.Duration batchCollectionPeriod = 6;
13+
google.protobuf.Duration eventTimeout =3;
14+
uint32 minResponsesToAggregate = 4;
15+
google.protobuf.Duration messageExpiry = 5;
16+
uint32 maxBatchSize = 6;
17+
google.protobuf.Duration batchCollectionPeriod = 7;
1718
}
1819

1920
// deprecated - v1 only

pkg/loop/internal/core/services/capability/capabilities_registry.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ func decodeRemoteTriggerConfig(prtc *capabilitiespb.RemoteTriggerConfig) *capabi
187187
remoteTriggerConfig := &capabilities.RemoteTriggerConfig{}
188188
remoteTriggerConfig.RegistrationRefresh = prtc.RegistrationRefresh.AsDuration()
189189
remoteTriggerConfig.RegistrationExpiry = prtc.RegistrationExpiry.AsDuration()
190+
remoteTriggerConfig.EventTimeout = prtc.EventTimeout.AsDuration()
190191
remoteTriggerConfig.MinResponsesToAggregate = prtc.MinResponsesToAggregate
191192
remoteTriggerConfig.MessageExpiry = prtc.MessageExpiry.AsDuration()
192193
remoteTriggerConfig.MaxBatchSize = prtc.MaxBatchSize

0 commit comments

Comments
 (0)