Extend Keystore Interface with Decrypt function#1467
Merged
cedric-cordenier merged 22 commits intomainfrom Aug 21, 2025
Merged
Conversation
product-security-plaid-test
bot
requested review from
DylanTinianov and
pavel-raykov
|
👋 vreff, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
vreff
force-pushed
the
PRIV-126-workflow-key
branch
from
bf77b62 to
98f0818
Compare
vreff
force-pushed
the
PRIV-126-workflow-key
branch
from
98f0818 to
f3f8753
Compare
jmank88
reviewed
Aug 12, 2025
vreff
requested review from
ChrisAmora,
EasterTheBunny,
FelixFan1992,
MStreet3,
bolekk,
cedric-cordenier,
chudilka1,
ecPablo,
ettec,
george-dorin,
jmank88 and
nolag
and removed request for
ChrisAmora,
FelixFan1992,
ettec and
george-dorin
jmank88
approved these changes
Aug 20, 2025
nadahalli
reviewed
Aug 21, 2025
| } | ||
|
|
||
| var P2PAccountKey = "P2P_SIGNER" | ||
| var StandardCapabilityAccount = "STANDARD_CAPABILITY_ACCOUNT" |
cedric-cordenier
approved these changes
Aug 21, 2025
apidiff results - backwards-incompatible changes detected ❌Module:
|
| Element | Change |
|---|---|
./pkg/types/core.Keystore.Decrypt |
added |
(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17129200560/#summary-48588572156)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Decryptfunction.NewSignerDecrypterto allow for both a signing and decryption key.Keystoreinterface to embed theUnimplementedKeystorestruct. Related: pkg/types/core: add UnimplementedKeystore #1475Update mocksCI step to theSolana Build Relayworkflow, such that interface changes are consumed by dependentchainlink-solanamocks during testing. Related: Remove intermediateSimpleKeystoreinterface chainlink-solana#1321Ultimately related to a Keystore change to enable Workflow key use by Capabilities. JIRA.