Conversation
|
👋 jmank88, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
✅ API Diff Results - No breaking changes |
jmank88
requested review from
cedric-cordenier,
ettec,
kirqz23,
krehermann,
pavel-raykov and
pkcll
jmank88
dismissed stale reviews from cll-gg, krehermann, pavel-raykov, and george-dorin
via
8c50ed7
jmank88
force-pushed
the
go-plugin-1.7.0
branch
from
1c63cb3 to
8c50ed7
Compare
jmank88
had a problem deploying
to
integration
GitHub Actions
Failure
jmank88
force-pushed
the
go-plugin-1.7.0
branch
from
8c50ed7 to
12410a8
Compare
jmank88
force-pushed
the
go-plugin-1.7.0
branch
from
12410a8 to
8e41175
Compare
jmank88
force-pushed
the
go-plugin-1.7.0
branch
from
8e41175 to
522b65d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 522b65d | Previous: 8e41175 | Ratio |
|---|---|---|---|
BenchmarkKeystore_Sign/nop/in-process |
771.3 ns/op |
368.2 ns/op |
2.09 |
This comment was automatically generated by workflow using github-action-benchmark.
| } else { | ||
| l.Debugw(msg, args...) |
There was a problem hiding this comment.
So this fallback isn't needed and leaving it out won't swallow any logs?
There was a problem hiding this comment.
The callers do it instead, since one case is Debug and the other is Error
6 participants
https://github.com/hashicorp/go-plugin/releases/tag/v1.7.0
This include panic log fixes that we had intended to do ourselves! 🎆