Add CCIP types required for Solana transmitter and codec migrations out of core#1555
Closed
amit-momin wants to merge 8 commits intoogt/extra-data-codec-registry-interface-v3from
Closed
Conversation
amit-momin
temporarily deployed
to
integration
GitHub Actions
Inactive
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
temporarily deployed
to
integration
GitHub Actions
Inactive
apidiff results - backwards-incompatible changes detected ❌Module:
|
| Element | Change |
|---|---|
./pkg/types.CCIPProviderArgs.OffRampAddress |
changed from string to github.com/smartcontractkit/chainlink-common/pkg/types/ccipocr3.UnknownAddress |
./pkg/types.CCIPProviderArgs.PluginType |
changed from uint32 to github.com/smartcontractkit/chainlink-common/pkg/types/ccipocr3.PluginType |
(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/17928109692/#summary-50979154015)
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
temporarily deployed
to
integration
GitHub Actions
Inactive
amit-momin
temporarily deployed
to
integration
GitHub Actions
Inactive
amit-momin
changed the title
amit-momin
force-pushed
the
feature/add-ccip-provider-plugin-type
branch
from
3e113e6 to
3ace32f
Compare
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
temporarily deployed
to
integration
GitHub Actions
Inactive
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
changed the base branch from
main
to
ogt/extra-data-codec-registry-interface-v3
ogtownsend
reviewed
Sep 17, 2025
Comment on lines
+377
to
+396
|
|
||
| // PluginType represents the type of CCIP plugin. | ||
| // It mirrors the OCRPluginType in Internal.sol. | ||
| type PluginType uint8 | ||
|
|
||
| const ( | ||
| PluginTypeCCIPCommit PluginType = 0 | ||
| PluginTypeCCIPExec PluginType = 1 | ||
| ) | ||
|
|
||
| func (pt PluginType) String() string { | ||
| switch pt { | ||
| case PluginTypeCCIPCommit: | ||
| return "CCIPCommit" | ||
| case PluginTypeCCIPExec: | ||
| return "CCIPExec" | ||
| default: | ||
| return "Unknown" | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
👍 and we can alias the one from chainlink/core/capabilities/ccip/types/types.go to point here
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
force-pushed
the
ogt/extra-data-codec-registry-interface-v3
branch
3 times, most recently
from
d712adb to
86877f3
Compare
amit-momin
force-pushed
the
feature/add-ccip-provider-plugin-type
branch
from
6ed0349 to
eec97e7
Compare
amit-momin
had a problem deploying
to
integration
GitHub Actions
Error
amit-momin
had a problem deploying
to
integration
GitHub Actions
Error
amit-momin
had a problem deploying
to
integration
GitHub Actions
Error
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
changed the title
amit-momin
force-pushed
the
feature/add-ccip-provider-plugin-type
branch
from
aa8b416 to
185e5e4
Compare
amit-momin
had a problem deploying
to
integration
GitHub Actions
Error
amit-momin
had a problem deploying
to
integration
GitHub Actions
Error
amit-momin
force-pushed
the
feature/add-ccip-provider-plugin-type
branch
from
185e5e4 to
a07d173
Compare
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
temporarily deployed
to
integration
GitHub Actions
Inactive
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
force-pushed
the
ogt/extra-data-codec-registry-interface-v3
branch
from
f3b4883 to
06d4446
Compare
amit-momin
force-pushed
the
feature/add-ccip-provider-plugin-type
branch
from
a2aef57 to
3994214
Compare
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
temporarily deployed
to
integration
GitHub Actions
Inactive
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
ogtownsend
force-pushed
the
ogt/extra-data-codec-registry-interface-v3
branch
from
06d4446 to
661a3a9
Compare
amit-momin
force-pushed
the
feature/add-ccip-provider-plugin-type
branch
from
3994214 to
915d7ed
Compare
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
had a problem deploying
to
integration
GitHub Actions
Failure
amit-momin
temporarily deployed
to
integration
GitHub Actions
Inactive
ogtownsend
force-pushed
the
ogt/extra-data-codec-registry-interface-v3
branch
from
661a3a9 to
3d1af8f
Compare
Contributor
Author
|
Changes included as part of #1561 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transmitterfield to CCIP provider args