Keystore library interfaces and admin create/delete#1580
Merged
connorwstein merged 19 commits intomainfrom Oct 6, 2025
Merged
Conversation
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
apidiff results - no incompatible changes detected ✅(Full summary: https://github.com/smartcontractkit/chainlink-common/actions/runs/18285044679/#summary-52057727917) |
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
commented
Oct 2, 2025
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
had a problem deploying
to
integration
GitHub Actions
Error
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
pavel-raykov
reviewed
Oct 3, 2025
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
…of github.com:smartcontractkit/chainlink-common into ARCH-328-keystore-interfaces-and-admin-implementation
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
reviewed
Oct 6, 2025
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
connorwstein
had a problem deploying
to
integration
GitHub Actions
Failure
connorwstein
temporarily deployed
to
integration
GitHub Actions
Inactive
jmank88
approved these changes
Oct 6, 2025
Contributor
jmank88
left a comment
jmank88
left a comment
There was a problem hiding this comment.
LGTM although I am wondering why GRPC chose to use pointers for their XRequest/XResponse types... 🤔 Maybe just efficiency?
Request seems annoying as a pointer, since you never pass nil. On the other hand, Response is cleaner as a pointer since you can return nil, err instead of explicit zero values.
pavel-raykov
approved these changes
Oct 6, 2025
connorwstein
deleted the
ARCH-328-keystore-interfaces-and-admin-implementation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://smartcontract-it.atlassian.net/browse/ARCH-328