Org Resolver in Initialise Depenencies loop wiring#1599
Merged
patrickhuie19 merged 7 commits intomainfrom Oct 8, 2025
Merged
Conversation
|
👋 patrickhuie19, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results - No breaking changes |
jmank88
reviewed
Oct 8, 2025
Comment on lines
26
to
45
| func (c *Client) Start(_ context.Context) error { | ||
| return nil | ||
| } | ||
|
|
||
| func (c *Client) HealthReport() map[string]error { | ||
| return map[string]error{c.Name(): nil} | ||
| } | ||
|
|
||
| func (c *Client) Close() error { | ||
| return nil | ||
| } | ||
|
|
||
| func (c *Client) Name() string { | ||
| return "OrgResolverClient" | ||
| } | ||
|
|
||
| func (c *Client) Ready() error { | ||
| return nil | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Does this need to implement Service?
Suggested change
| func (c *Client) Start(_ context.Context) error { | |
| return nil | |
| } | |
| func (c *Client) HealthReport() map[string]error { | |
| return map[string]error{c.Name(): nil} | |
| } | |
| func (c *Client) Close() error { | |
| return nil | |
| } | |
| func (c *Client) Name() string { | |
| return "OrgResolverClient" | |
| } | |
| func (c *Client) Ready() error { | |
| return nil | |
| } |
Contributor
Author
There was a problem hiding this comment.
If we don't, won't any consumer of the service in the capabilities get hit with a panic if they try to call these methods?
Contributor
There was a problem hiding this comment.
jmank88
reviewed
Oct 8, 2025
Co-authored-by: Jordan Krage <jmank88@gmail.com>
jmank88
approved these changes
Oct 8, 2025
vyzaldysanchez
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds grpc wiring for 392db6d
capabilities using org resolver from initialise: https://github.com/smartcontractkit/capabilities/pull/295
core node wiring org resolver to initialise smartcontractkit/chainlink#19798
adding org resolver to the standard cap dependencies struct: #1597