Skip to content

Org Resolver in Initialise Depenencies loop wiring#1599

Merged
patrickhuie19 merged 7 commits intomainfrom
feat/org-resolver-loop-wiring
Oct 8, 2025
Merged

Org Resolver in Initialise Depenencies loop wiring#1599
patrickhuie19 merged 7 commits intomainfrom
feat/org-resolver-loop-wiring

Conversation

@patrickhuie19
Copy link
Contributor

@patrickhuie19 patrickhuie19 commented Oct 8, 2025

Adds grpc wiring for 392db6d

capabilities using org resolver from initialise: https://github.com/smartcontractkit/capabilities/pull/295
core node wiring org resolver to initialise smartcontractkit/chainlink#19798
adding org resolver to the standard cap dependencies struct: #1597

@github-actions
Copy link

github-actions bot commented Oct 8, 2025

👋 patrickhuie19, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@patrickhuie19 patrickhuie19 changed the title Feat/org resolver loop wiring Org Resolver in Initialise Depenencies loop wiring Oct 8, 2025
@github-actions
Copy link

github-actions bot commented Oct 8, 2025

✅ API Diff Results - No breaking changes


📄 View full apidiff report | 📚 Learn about apidiff

Comment on lines 26 to 45
func (c *Client) Start(_ context.Context) error {
return nil
}

func (c *Client) HealthReport() map[string]error {
return map[string]error{c.Name(): nil}
}

func (c *Client) Close() error {
return nil
}

func (c *Client) Name() string {
return "OrgResolverClient"
}

func (c *Client) Ready() error {
return nil
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to implement Service?

Suggested change
func (c *Client) Start(_ context.Context) error {
return nil
}
func (c *Client) HealthReport() map[string]error {
return map[string]error{c.Name(): nil}
}
func (c *Client) Close() error {
return nil
}
func (c *Client) Name() string {
return "OrgResolverClient"
}
func (c *Client) Ready() error {
return nil
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't, won't any consumer of the service in the capabilities get hit with a panic if they try to call these methods?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Jordan Krage <jmank88@gmail.com>
@patrickhuie19 patrickhuie19 enabled auto-merge (squash) October 8, 2025 20:26
@patrickhuie19 patrickhuie19 merged commit 7ec0a00 into main Oct 8, 2025
20 of 22 checks passed
@patrickhuie19 patrickhuie19 deleted the feat/org-resolver-loop-wiring branch October 8, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants