Conversation
|
👋 nadahalli, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
✅ API Diff Results - No breaking changes |
pavel-raykov
previously approved these changes
Oct 16, 2025
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
product-security-plaid-production
bot
requested review from
ettec,
george-dorin and
ilija42
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
ilija42
reviewed
Oct 20, 2025
| const file_capabilities_internal_basictrigger_v1_basic_trigger_proto_rawDesc = "" + | ||
| "\n" + | ||
| "9capabilities/internal/basictrigger/v1/basic_trigger.proto\x12%capabilities.internal.basictrigger.v1\x1a)tools/generator/v1beta/cre_metadata.proto\"4\n" + | ||
| "9capabilities/internal/basictrigger/v1/basic_trigger.proto\x12%capabilities.internal.basictrigger.v1\x1a*tools/generator/v1alpha/cre_metadata.proto\"4\n" + |
Contributor
There was a problem hiding this comment.
isn't beta -> alpha a downgrade?
Contributor
Author
There was a problem hiding this comment.
Seems like it. But apparently, the beta upgrade was rolled back? I am really not sure about this. @MStreet3 should know the facts.
Contributor
Author
There was a problem hiding this comment.
Also, this PR depends on a commit that is not a part of main yet. Waiting for smartcontractkit/chainlink-protos#218 to get merged.
Contributor
Author
There was a problem hiding this comment.
smartcontractkit/chainlink-protos#218 got merged, and I have used the updated version here. This is good for review now.
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
Contributor
Author
|
Please take another look. |
pavel-raykov
approved these changes
Oct 21, 2025
jmank88
approved these changes
Oct 21, 2025
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
nadahalli
had a problem deploying
to
integration
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports