Skip to content

CRE-1330#1703

Merged
pavel-raykov merged 6 commits intomainfrom
cre-1330
Nov 13, 2025
Merged

CRE-1330#1703
pavel-raykov merged 6 commits intomainfrom
cre-1330

Conversation

@mchain0
Copy link
Contributor

@mchain0 mchain0 commented Nov 13, 2025

@mchain0 mchain0 marked this pull request as ready for review November 13, 2025 10:53
@mchain0 mchain0 requested a review from a team as a code owner November 13, 2025 10:53
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

✅ API Diff Results - No breaking changes


📄 View full apidiff report

pavel-raykov
pavel-raykov previously approved these changes Nov 13, 2025
agparadiso
agparadiso previously approved these changes Nov 13, 2025
ettec
ettec previously approved these changes Nov 13, 2025
jmank88
jmank88 previously approved these changes Nov 13, 2025
chudilka1
chudilka1 previously approved these changes Nov 13, 2025
chainchad
chainchad previously approved these changes Nov 13, 2025
@mchain0 mchain0 added this pull request to the merge queue Nov 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2025
@jmank88
Copy link
Contributor

jmank88 commented Nov 13, 2025

@chainchad Do we need to configure the linter differently to handle --only-new-issues correctly?

@chainchad
Copy link
Contributor

@chainchad Do we need to configure the linter differently to handle --only-new-issues correctly?

The default behavior for the upstream composite action is to use this flag if that's what you mean: https://github.com/smartcontractkit/.github/blob/main/actions/ci-lint-go/action.yml#L67-L70

@jmank88
Copy link
Contributor

jmank88 commented Nov 13, 2025

@chainchad Do we need to configure the linter differently to handle --only-new-issues correctly?

The default behavior for the upstream composite action is to use this flag if that's what you mean: smartcontractkit/.github@main/actions/ci-lint-go/action.yml#L67-L70

But why did we pass on the PR, but fail in the queue?

level=warning msg="[runner] Can't process results by diff processor: can't prepare diff by revgrep: could not read git repo: error executing \"git diff --color=never --no-ext-diff --default-prefix --relative 58a50811fe85b393f13288164645e210cdf07f7d --\": exit status 128: fatal: bad object 58a50811fe85b393f13288164645e210cdf07f7d\n"

@mchain0 mchain0 added this pull request to the merge queue Nov 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 13, 2025
jmank88
jmank88 previously approved these changes Nov 13, 2025
jmank88
jmank88 previously approved these changes Nov 13, 2025
@pavel-raykov pavel-raykov added this pull request to the merge queue Nov 13, 2025
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2025
Merged via the queue into main with commit d4d0f38 Nov 13, 2025
27 of 28 checks passed
@pavel-raykov pavel-raykov deleted the cre-1330 branch November 13, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments