-
Notifications
You must be signed in to change notification settings - Fork 25
[ARCH-327] Address security comments #1758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ API Diff Results - No breaking changes |
42e2669 to
07f0bb1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request addresses security-related feedback by implementing input validation, improving error handling, and preventing accidental logging of sensitive data.
Key Changes:
- Added validation for key name and metadata length limits
- Implemented input validation for Ed25519 and X25519 private key sizes
- Enhanced the
Rawtype to prevent accidental logging through theFormatmethod
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| keystore/admin.go | Introduces constants for max key name and metadata lengths, adds validation checks, and refactors to use these constants |
| keystore/keystore.go | Adds private key size validation for Ed25519 and X25519 key types, reorganizes imports |
| keystore/internal/raw.go | Implements Format method to prevent accidental logging of sensitive data via fmt verbs |
| keystore/reader.go | Refactors to use newKeyInfo helper function for consistency |
| keystore/admin_test.go | Updates test to compare individual key fields instead of entire structs to handle CreatedAt field differences |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1f17bf9 to
dcb3e77
Compare
No description provided.