-
Notifications
You must be signed in to change notification settings - Fork 25
Adding MaxGasPrice to GasConfig #1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a MaxGasPrice field to the GasConfig struct in the EVM chain capabilities, allowing users to specify a maximum gas price in wei for transactions. The change is implemented in the generated protobuf code.
Changes:
- Added optional
MaxGasPricefield of type*pb.BigInttoGasConfigstruct - Added getter method
GetMaxGasPrice()for the new field - Updated protobuf version dependencies and raw descriptor data
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/capabilities/v2/chain-capabilities/evm/client.pb.go | Added MaxGasPrice field to GasConfig struct with corresponding getter method and protobuf descriptor updates |
| go.mod | Added local replace directive for chainlink-protos dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
go.mod
Outdated
|
|
||
| replace github.com/smartcontractkit/chainlink-protos/cre/go => /Users/yashvardhan/chainlink-protos/cre/go |
Copilot
AI
Jan 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This replace directive uses an absolute local file path specific to a user's machine (/Users/yashvardhan/...). This will break for other developers and CI/CD pipelines. Remove this replace directive before merging, or use a relative path if local development requires it.
| replace github.com/smartcontractkit/chainlink-protos/cre/go => /Users/yashvardhan/chainlink-protos/cre/go |
✅ API Diff Results - No breaking changes |
https://smartcontract-it.atlassian.net/browse/PLEX-1522
Depends on smartcontractkit/chainlink-protos#256