Skip to content

Create Limits for the confidential-http capability #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prashantkumar1982 merged 6 commits into from
Feb 3, 2026
Merged

Create Limits for the confidential-http capability #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
065a9ac
Create Limits for the comfidential-http capability
prashantkumar1982 Jan 30, 2026
9c95f42
Merge branch 'main' of https://github.com/smartcontractkit/chainlink-…
prashantkumar1982 Jan 30, 2026
66c228a
nit rename
prashantkumar1982 Jan 30, 2026
bc10b8c
Merge branch 'main' of https://github.com/smartcontractkit/chainlink-…
prashantkumar1982 Feb 2, 2026
cd6ae79
nit
prashantkumar1982 Feb 2, 2026
09cf479
merge main
prashantkumar1982 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/settings/cresettings/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,14 @@ flowchart
PerWorkflow.HTTPAction.RequestSizeLimit{{RequestSizeLimit}}:::bound
PerWorkflow.HTTPAction.ResponseSizeLimit{{ResponseSizeLimit}}:::bound
end
subgraph PerWorkflow.ConfidentialHTTP
direction LR

PerWorkflow.ConfidentialHTTP.CallLimit{{CallLimit}}:::bound
PerWorkflow.ConfidentialHTTP.ConnectionTimeout{{ConnectionTimeout}}:::bound
PerWorkflow.ConfidentialHTTP.RequestSizeLimit{{RequestSizeLimit}}:::bound
PerWorkflow.ConfidentialHTTP.ResponseSizeLimit{{ResponseSizeLimit}}:::bound
end
subgraph PerWorkflow.Secrets
PerWorkflow.Secrets.CallLimit{{CallLimit}}:::bound
end
Expand Down
6 changes: 6 additions & 0 deletions pkg/settings/cresettings/defaults.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,12 @@
"RequestSizeLimit": "10kb",
"ResponseSizeLimit": "100kb"
},
"ConfidentialHTTP": {
"CallLimit": "5",
"ConnectionTimeout": "10s",
"RequestSizeLimit": "10kb",
"ResponseSizeLimit": "100kb"
},
"Secrets": {
"CallLimit": "5"
}
Expand Down
6 changes: 6 additions & 0 deletions pkg/settings/cresettings/defaults.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,5 +86,11 @@ ConnectionTimeout = '10s'
RequestSizeLimit = '10kb'
ResponseSizeLimit = '100kb'

[PerWorkflow.ConfidentialHTTP]
CallLimit = '5'
ConnectionTimeout = '10s'
RequestSizeLimit = '10kb'
ResponseSizeLimit = '100kb'

[PerWorkflow.Secrets]
CallLimit = '5'
23 changes: 18 additions & 5 deletions pkg/settings/cresettings/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,12 @@ var Default = Schema{
RequestSizeLimit: Size(10 * config.KByte),
ResponseSizeLimit: Size(100 * config.KByte),
},
ConfidentialHTTP: confidentialHTTP{
CallLimit: Int(5),
ConnectionTimeout: Duration(10 * time.Second),
RequestSizeLimit: Size(10 * config.KByte),
ResponseSizeLimit: Size(100 * config.KByte),
},
Secrets: secrets{
CallLimit: Int(5),
},
Expand Down Expand Up @@ -213,11 +219,12 @@ type Workflows struct {
HTTPTrigger httpTrigger
LogTrigger logTrigger

ChainWrite chainWrite
ChainRead chainRead
Consensus consensus
HTTPAction httpAction
Secrets secrets
ChainWrite chainWrite
ChainRead chainRead
Consensus consensus
HTTPAction httpAction
ConfidentialHTTP confidentialHTTP
Secrets secrets
}

type cronTrigger struct {
Expand Down Expand Up @@ -254,6 +261,12 @@ type httpAction struct {
RequestSizeLimit Setting[config.Size]
ResponseSizeLimit Setting[config.Size]
}
type confidentialHTTP struct {
CallLimit Setting[int] `unit:"{call}"`
ConnectionTimeout Setting[time.Duration]
RequestSizeLimit Setting[config.Size]
ResponseSizeLimit Setting[config.Size]
}
type secrets struct {
CallLimit Setting[int] `unit:"{call}"`
}
Expand Down
8 changes: 8 additions & 0 deletions pkg/settings/cresettings/settings_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ func TestSchema_Unmarshal(t *testing.T) {
"CallLimit": "5",
"CacheAgeLimit": "5m"
},
"ConfidentialHTTP": {
"CallLimit": "5",
"ConnectionTimeout": "10s",
"RequestSizeLimit": "10kb",
"ResponseSizeLimit": "100kb"
},
"Secrets": {
"CallLimit": "5"
},
Expand Down Expand Up @@ -126,6 +132,8 @@ func TestSchema_Unmarshal(t *testing.T) {
assert.Equal(t, config.Rate{Limit: rate.Every(13 * time.Second), Burst: 6}, cfg.PerWorkflow.LogTrigger.EventRateLimit.DefaultValue)
assert.Equal(t, 5, cfg.PerWorkflow.HTTPAction.CallLimit.DefaultValue)
assert.Equal(t, 5*time.Minute, cfg.PerWorkflow.HTTPAction.CacheAgeLimit.DefaultValue)
assert.Equal(t, 5, cfg.PerWorkflow.ConfidentialHTTP.CallLimit.DefaultValue)
assert.Equal(t, 10*config.KByte, cfg.PerWorkflow.ConfidentialHTTP.RequestSizeLimit.DefaultValue)
assert.Equal(t, 5, cfg.PerWorkflow.Secrets.CallLimit.DefaultValue)
assert.Equal(t, uint64(500000), cfg.PerWorkflow.ChainWrite.EVM.TransactionGasLimit.DefaultValue)
assert.Equal(t, 3, cfg.PerWorkflow.ChainRead.CallLimit.DefaultValue)
Expand Down
Loading