Conversation
brunotm
requested changes
Mar 9, 2026
Contributor
brunotm
left a comment
brunotm
left a comment
There was a problem hiding this comment.
This is a really good catch @calvwang9 🚀
But we can't do the full encode on the IsEncodable as this has the potential of substantially increase/impact the cpu time and outcome generation time under the right (wrong) conditions.
We should instead verify that all elements for encoding are present and valid:
- All stream values are present and are not nil
- All required timestamps are present and valid
- etc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
full bug report: https://docs.google.com/document/d/1lJaCveFuS7oFW4sAF5A7-H7sSOYJOkpo88X4JPZ17ys/edit?usp=sharing
This change addresses a bug in the LLO outcome plugins that results in report gaps.
The bug:
Currently a channel's validAfterNanoseconds is updated to the previous observationsTimestamp field based on the
IsReportablecheck on the previous outcome only. This check doesnt have any knowledge about whether a report was actually generated from the previous outcome, so when reports are (silently) dropped due to missing stream values or otherwise, valid after updates regardless, leading to a continuity error/report gap.The fix:
Add a simulation check in the outcome step to perform a soft check for whether the previous outcome would have successfully produced a report, and do not update the valid after timestamp if not. This will catch the most common fail cases related to nil stream values.
However this is not a hard guarantee on report success - outcomes are produced before reports, and there is no feedback from report generation to the next round of outcome generation. If the report was dropped for any other reasons it would not be caught by this simulation.