[CLD-149]: fix: Migrate legacy addressbook from Chainlink#2
Merged
Conversation
|
b3c1eda to
2abbcc5
Compare
Files migrated from chainlink repo - address_book.go - address_book_test.go - address_book_labels.go -> renamed to labels - address_book_labels_test.go JIRA: https://smartcontract-it.atlassian.net/browse/CLD-149
2abbcc5 to
fa61846
Compare
jkongie
approved these changes
Apr 11, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## chainlink-deployments-framework@0.18.0 ### Minor Changes - [#230](#230) [`149c03f`](149c03f) Thanks [@graham-chainlink](https://github.com/graham-chainlink)! - introduce Catalog GRPC client ### Patch Changes - [#229](#229) [`4ea8e79`](4ea8e79) Thanks [@giogam](https://github.com/giogam)! - Catalog Datastore #2 --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start with something simple and least likely to change
This is a lift and shift, i am avoiding any improvements or refactoring that can be done. Beside i think this package will be deleted in future once Datastore is fully rolled out
Files migrated from chainlink repo
However I did not migrate the snippet below found here, i think this is quite specific to ccip
JIRA: https://smartcontract-it.atlassian.net/browse/CLD-149