Skip to content

[CLD-149]: fix: Migrate legacy addressbook from Chainlink#2

Merged
jkongie merged 1 commit intomainfrom
ggoh/CLD-149/address-book
Apr 11, 2025
Merged

[CLD-149]: fix: Migrate legacy addressbook from Chainlink#2
jkongie merged 1 commit intomainfrom
ggoh/CLD-149/address-book

Conversation

@graham-chainlink
Copy link
Collaborator

@graham-chainlink graham-chainlink commented Apr 11, 2025

Start with something simple and least likely to change

This is a lift and shift, i am avoiding any improvements or refactoring that can be done. Beside i think this package will be deleted in future once Datastore is fully rolled out

Files migrated from chainlink repo

  • address_book.go
  • address_book_test.go
  • address_book_labels.go -> renamed to labels
  • address_book_labels_test.go

However I did not migrate the snippet below found here, i think this is quite specific to ccip

var (
	Version0_5_0 = *semver.MustParse("0.5.0")
	Version1_0_0 = *semver.MustParse("1.0.0")
	Version1_1_0 = *semver.MustParse("1.1.0")
	Version1_2_0 = *semver.MustParse("1.2.0")
	Version1_5_0 = *semver.MustParse("1.5.0")
	Version1_5_1 = *semver.MustParse("1.5.1")
	Version1_6_0 = *semver.MustParse("1.6.0")
)

JIRA: https://smartcontract-it.atlassian.net/browse/CLD-149

@graham-chainlink graham-chainlink requested a review from a team as a code owner April 11, 2025 04:37
@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2025

⚠️ No Changeset found

Latest commit: fa61846

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graham-chainlink graham-chainlink force-pushed the ggoh/CLD-149/address-book branch 2 times, most recently from b3c1eda to 2abbcc5 Compare April 11, 2025 04:40
Files migrated from chainlink repo
- address_book.go
- address_book_test.go
- address_book_labels.go  -> renamed to labels
- address_book_labels_test.go

JIRA: https://smartcontract-it.atlassian.net/browse/CLD-149
@graham-chainlink graham-chainlink force-pushed the ggoh/CLD-149/address-book branch from 2abbcc5 to fa61846 Compare April 11, 2025 05:00
@jkongie jkongie added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 439d8f2 Apr 11, 2025
5 checks passed
@jkongie jkongie deleted the ggoh/CLD-149/address-book branch April 11, 2025 05:06
github-merge-queue bot pushed a commit that referenced this pull request Jul 17, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## chainlink-deployments-framework@0.18.0

### Minor Changes

-
[#230](#230)
[`149c03f`](149c03f)
Thanks [@graham-chainlink](https://github.com/graham-chainlink)! -
introduce Catalog GRPC client

### Patch Changes

-
[#229](#229)
[`4ea8e79`](4ea8e79)
Thanks [@giogam](https://github.com/giogam)! - Catalog Datastore #2

---------

Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants