Conversation
|
| ci-lint: | ||
| name: Lint | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| actions: read | ||
| steps: | ||
| - name: Linting Go | ||
| uses: smartcontractkit/.github/actions/ci-lint-go@eeb76b5870e3c17856d5a60fd064a053c023b5f5 # ci-lint-go@1.0.0 | ||
| with: | ||
| golangci-lint-version: v2.0.2 | ||
| # Override the lint args because the detault ones are not compatible with golangci-lint v2 | ||
| golangci-lint-args: --output.checkstyle.path=golangci-lint-report.xml | ||
|
|
||
| ci-test: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| id-token: write | ||
| contents: read | ||
| actions: read | ||
| steps: | ||
| - name: ci-test | ||
| uses: smartcontractkit/.github/actions/ci-test-go@eeb76b5870e3c17856d5a60fd064a053c023b5f5 # ci-test-go@1.0.0 |
There was a problem hiding this comment.
Do we actually need this to run on release?
Since it's not a needs on the publish, they are just running and are not a blocker for a release
There was a problem hiding this comment.
oh nice pick up, i copied this from MCMS, but i think you are right, the changesets raise a PR before pushing a tag, that PR will have all the required ci checks so we dont have to duplicate here again.
Removing it.
graham-chainlink
force-pushed
the
ggoh/cld-127/setup-changesets
branch
from
ee665d5 to
5865871
Compare
- Add push tag workflow - setup goreleaser config - npm commands to running changeset release
graham-chainlink
force-pushed
the
ggoh/cld-127/setup-changesets
branch
from
5865871 to
9cb2ef7
Compare
2 participants
JIRA: https://smartcontract-it.atlassian.net/browse/CLD-127