Skip to content

fix: get delay for advancing time from the proposal instead of constant #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecPablo merged 1 commit into from
Oct 7, 2025
Merged

fix: get delay for advancing time from the proposal instead of constant #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pretty-days-draw.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"chainlink-deployments-framework": patch
---

get delay for advancing time from the proposal instead of constant value
4 changes: 2 additions & 2 deletions engine/cld/legacy/cli/mcmsv2/mcms_v2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ const (
proposalKindFlag = "proposalKind"
indexFlag = "index"
forkFlag = "fork"
defaultAdvanceTime = 36000 // In seconds - defaulting to 10 hours
defaultProposalValidity = 72 * time.Hour
)

Expand Down Expand Up @@ -666,7 +665,8 @@ func buildExecuteForkCommand(lggr logger.Logger, domain cldf_domain.Domain, prop
}
lggr.Info("MCMs execute() success")
lggr.Info("Waiting for the chain to be mined before executing timelock chain command")
if err = anvilClient.EVMIncreaseTime(defaultAdvanceTime); err != nil {

if err = anvilClient.EVMIncreaseTime(uint64(cfg.timelockProposal.Delay.Seconds())); err != nil {
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converting time.Duration to uint64 via Seconds() may lose precision for sub-second delays and could truncate fractional seconds. Consider using a more precise conversion or validating that the delay is appropriate for the EVMIncreaseTime API.

Suggested change
if err = anvilClient.EVMIncreaseTime(uint64(cfg.timelockProposal.Delay.Seconds())); err != nil {
// Round up to the nearest whole second to avoid truncating sub-second delays
delaySeconds := uint64((cfg.timelockProposal.Delay + time.Second - 1) / time.Second)
if err = anvilClient.EVMIncreaseTime(delaySeconds); err != nil {

Copilot uses AI. Check for mistakes.
return fmt.Errorf("failed to increase time: %w", err)
}
if err = anvilClient.AnvilMine([]interface{}{1}); err != nil {
Expand Down